From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6866 invoked by alias); 17 Sep 2013 13:35:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6853 invoked by uid 89); 17 Sep 2013 13:35:33 -0000 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 17 Sep 2013 13:35:33 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8F489116451; Tue, 17 Sep 2013 09:35:44 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kl5RzUW5f-hn; Tue, 17 Sep 2013 09:35:44 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 67D99116440; Tue, 17 Sep 2013 09:35:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4A236E1290; Tue, 17 Sep 2013 06:35:30 -0700 (PDT) Date: Tue, 17 Sep 2013 13:35:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] Match \r\r\n in testsuite Message-ID: <20130917133530.GH3132@adacore.com> References: <87a9ldyu8k.fsf@fleche.redhat.com> <1379423179-8515-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379423179-8515-1-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-09/txt/msg00507.txt.bz2 > Then, I restarted from the beginning again, and see if we can fix the > problem by modifying testsuite. The requirement expressed in the > previous patch review is that we should localize the changes to > testsuite to match \r\r\n. > > This patch series is to change testsuite to match both \r\n and > \r\r\n by modifying pattern to \r+\n in a localized manner. Patch 1/4 > is to replace gdb_test with gdb_test_sequence to match the output of > "info tracepoints", so that the assumption of last character of each > line is removed, so these patterns can be matched on all targets. > Patch 2/4 is to transform \r\n in patterns to \r+\n, but \r\n in > variables can't be transformed. Patch 3/4 transforms \r\n in variables. How about we introduce a new official variable, similar to $hex, $decimal, etc, which would correctly match new-line output based on the host? I propose $eol, which is already used, but only in 2 testcases, so easy to adjust (remove "set eol ..." in those two testcases). -- Joel