From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] native mingw32 gdb, eol format
Date: Sat, 20 Jul 2013 06:55:00 -0000 [thread overview]
Message-ID: <837gglzpn7.fsf@gnu.org> (raw)
In-Reply-To: <51E9DBD4.4070605@codesourcery.com>
> Date: Sat, 20 Jul 2013 08:37:40 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: <gdb-patches@sourceware.org>
>
> > This is a problem with the test suite, so please fix it in the test
> > suite. If you_must_ make the change in GDB, please introduce some
> > specialized option to do that. But changing the default behavior like
> > that is IMO a no-starter.
>
> Looks fixing the testsuite to allow '\r\r\n' is a promising approach,
> however it is not a small piece of work. The patch below is a
> proof-of-concept implementation, and we need to apply the change (\r
> -> ${cr}) to the testsuite. Please let me know is it what you
> want, and then I can evaluate how much efforts are needed here.
It is fine with me, but I don't know enough about the test suite to
give you a definitive approval. I'm sure others will respond.
Thanks.
next prev parent reply other threads:[~2013-07-20 6:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 1:07 Yao Qi
2013-07-16 2:50 ` Eli Zaretskii
2013-07-20 0:38 ` Yao Qi
2013-07-20 6:55 ` Eli Zaretskii [this message]
2013-07-23 19:03 ` Tom Tromey
2013-07-23 19:08 ` Eli Zaretskii
2013-07-23 20:58 ` Tom Tromey
2013-07-24 3:46 ` Eli Zaretskii
2013-07-24 9:09 ` Yao Qi
2013-09-17 13:07 ` [PATCH 0/4] Match \r\r\n in testsuite Yao Qi
2013-09-17 13:07 ` [PATCH 4/4] Replace "." with "\r+" Yao Qi
2013-09-17 13:07 ` [PATCH 1/4] Use gdb_test_sequence to test "info tracepoints" Yao Qi
2013-09-17 13:07 ` [PATCH 3/4] Transform \r\n in MI variables Yao Qi
2013-09-17 13:07 ` [PATCH 2/4] Transform "\r\n" in pattern to "\r+\n" Yao Qi
2013-09-17 23:11 ` Pierre Muller
2013-09-17 13:35 ` [PATCH 0/4] Match \r\r\n in testsuite Joel Brobecker
2013-09-17 13:59 ` Yao Qi
2013-09-17 14:06 ` Joel Brobecker
2013-09-18 8:21 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837gglzpn7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox