[PATCH 0/4] Match \r\r\n in testsuite

Yao Qi
2013-09-17T13:07:06Z

This is a follow-up to the thread

[PATCH] native mingw32 gdb, eol format
https://sourceware.org/ml/gdb-patches/2013-07/msg00358.html

At the very beginning, I proposed to either add a new option or set
stderr/stdout to binary mode, neither is acceptable because of its
drawback. We don't want to add a new option only for running
testsuite on a certain configuration, and don't want to change GDB's
output behavior.

Then, I restarted from the beginning again, and see if we can fix the
problem by modifying testsuite. The requirement expressed in the
previous patch review is that we should localize the changes to
testsuite to match \r\r\n.

This patch series is to change testsuite to match both \r\n and
\r\r\n by modifying pattern to \r+\n in a localized manner. Patch 1/4
is to replace gdb_test with gdb_test_sequence to match the output of
"info tracepoints", so that the assumption of last character of each
line is removed, so these patterns can be matched on all targets.
Patch 2/4 is to transform \r\n in patterns to \r+\n, but \r\n in
variables can't be transformed. Patch 3/4 transforms \r\n in variables.

The whole series are tested on mingw32 native gdb, and compared with
running gdb with stdout/stderr setting to binary mode. No extra fails.

*** BLURB HERE ***

Yao Qi (4):
Use gdb_test_sequence to test "info tracepoints"
Transform "\r\n" in pattern to "\r+\n"
Transform \r\n in MI variables
Replace "." with "\r+".

gdb/testsuite/gdb.trace/actions.exp | 119 +++++++++--------
gdb/testsuite/gdb.trace/deltrace.exp | 78 ++++++------
gdb/testsuite/gdb.trace/infotrace.exp | 36 +++---
gdb/testsuite/gdb.trace/passcount.exp | 200 ++++++++++++++-------------
gdb/testsuite/gdb.trace/tracecmd.exp | 12 +-
gdb/testsuite/gdb.trace/while-stepping.exp | 25 ++--
gdb/testsuite/lib/gdb.exp | 22 +++
gdb/testsuite/lib/mi-support.exp | 12 +-
8 files changed, 273 insertions(+), 231 deletions(-)

--
1.7.7.6