Re: [PATCH 0/4] Match \r\r\n in testsuite

Yao Qi
2013-09-18T08:21:01Z

On 09/17/2013 10:06 PM, Joel Brobecker wrote:
> Can we look at fixing gdb_test to use that $eol instead? Is that
> even necessary? I see the implementation is:
>
> return [gdb_test_multiple $command $message {
> -re "\[\r\n\]*($pattern)\[\r\n\]+$gdb_prompt $" {
> if ![string match "" $message] then {
> pass "$message"
> }
> }
>
> It seems to me that it should match ${eol} already, no?

Yes, this pattern above should match ${eol}. However, how about the
code using gdb_test_mulitiple or gdb_expect to match? We have to fix
them too. We don't want to replace all instances of \r\n with ${eol},
which is painful.

--
Yao (é½å°§)