From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30997 invoked by alias); 18 Sep 2013 08:21:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30987 invoked by uid 89); 18 Sep 2013 08:21:01 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2013 08:21:01 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.7 required=5.0 tests=AWL,BAYES_20,GARBLED_BODY,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VMD0K-0006OL-7Q from Yao_Qi@mentor.com ; Wed, 18 Sep 2013 01:20:56 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 18 Sep 2013 01:20:56 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Wed, 18 Sep 2013 01:20:55 -0700 Message-ID: <52396242.9090008@codesourcery.com> Date: Wed, 18 Sep 2013 08:21:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [PATCH 0/4] Match \r\r\n in testsuite References: <87a9ldyu8k.fsf@fleche.redhat.com> <1379423179-8515-1-git-send-email-yao@codesourcery.com> <20130917133530.GH3132@adacore.com> <52386003.2050501@codesourcery.com> <20130917140603.GK3132@adacore.com> In-Reply-To: <20130917140603.GK3132@adacore.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00568.txt.bz2 On 09/17/2013 10:06 PM, Joel Brobecker wrote: > Can we look at fixing gdb_test to use that $eol instead? Is that > even necessary? I see the implementation is: > > return [gdb_test_multiple $command $message { > -re "\[\r\n\]*($pattern)\[\r\n\]+$gdb_prompt $" { > if ![string match "" $message] then { > pass "$message" > } > } > > It seems to me that it should match ${eol} already, no? Yes, this pattern above should match ${eol}. However, how about the code using gdb_test_mulitiple or gdb_expect to match? We have to fix them too. We don't want to replace all instances of \r\n with ${eol}, which is painful. -- Yao (齐尧)