From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103420-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8053 invoked by alias); 16 Jul 2013 02:50:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 8023 invoked by uid 89); 16 Jul 2013 02:50:07 -0000
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from Unknown (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 16 Jul 2013 02:50:05 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MQ000800D6VHM00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Tue, 16 Jul 2013 05:49:56 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MQ00089ED787EA0@a-mtaout20.012.net.il>; Tue, 16 Jul 2013 05:49:56 +0300 (IDT)
Date: Tue, 16 Jul 2013 02:50:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] native mingw32 gdb, eol format
In-reply-to: <1373936767-14858-1-git-send-email-yao@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ppuj2p7r.fsf@gnu.org>
References: <1373936767-14858-1-git-send-email-yao@codesourcery.com>
X-SW-Source: 2013-07/txt/msg00360.txt.bz2

> From: Yao Qi <yao@codesourcery.com>
> Date: Tue, 16 Jul 2013 09:06:07 +0800
> 
> This patch, which was written by Pedro, is to force stdout/stderr to
> binary mode prevents that expansion.  This patch gets much
> improvement on the test result of  mingw native gdb.  Is it OK?

No, it's not.  A MinGW GDB is a native Windows program, and should
behave like one.  Windows programs generally don't expect text coming
through pipes to have Unix EOL format.  Also, it is terribly confusing
to have GDB behave differently with its standard handles redirected to
a pipe as opposed to disk files or the console device.

This is a problem with the test suite, so please fix it in the test
suite.  If you _must_ make the change in GDB, please introduce some
specialized option to do that.  But changing the default behavior like
that is IMO a no-starter.