From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: gdb-patches@sourceware.org, palves@redhat.com
Subject: Re: [PATCH] Extra error message from update_watchpoint
Date: Tue, 29 Oct 2013 17:19:00 -0000 [thread overview]
Message-ID: <83ob68dmfb.fsf@gnu.org> (raw)
In-Reply-To: <526FE5E9.3000909@broadcom.com>
> Date: Tue, 29 Oct 2013 16:44:25 +0000
> From: "Andrew Burgess" <aburgess@broadcom.com>
> cc: "Pedro Alves" <palves@redhat.com>
>
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 608463d..68b348d 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -1805,7 +1805,8 @@ update_watchpoint (struct watchpoint *b, int reparse)
> if (b->base.ops->works_in_software_mode (&b->base))
> b->base.type = bp_watchpoint;
> else
> - error (_("Software read/access watchpoints not supported."));
> + error (_("Hardware watchpoint support disabled. "
> + "See set/show can-use-hw-watchpoints."));
Sorry for chiming in late, but IMO this change is a step backwards:
the new warning is much more puzzling than the old one. The old one
at least told what was the problem, the new one looks like entirely
unrelated (unless you are privy to GDB internals).
How about something like
Cannot set read/access watchpoints without hardware watchpoint support.
next prev parent reply other threads:[~2013-10-29 17:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 9:20 Andrew Burgess
2013-10-18 17:18 ` Pedro Alves
2013-10-29 16:44 ` Andrew Burgess
2013-10-29 17:09 ` Pedro Alves
2013-10-29 17:19 ` Eli Zaretskii [this message]
2013-10-29 17:38 ` Andrew Burgess
2013-10-29 17:52 ` Pedro Alves
2013-10-29 19:09 ` Eli Zaretskii
2013-10-30 11:49 ` Andrew Burgess
2013-10-30 15:41 ` Eli Zaretskii
2013-10-30 17:13 ` Andrew Burgess
2013-10-30 18:41 ` Eli Zaretskii
2013-10-31 13:05 ` Andrew Burgess
2013-10-30 18:48 ` Pedro Alves
2013-10-30 19:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ob68dmfb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox