From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Extra error message from update_watchpoint
Date: Fri, 18 Oct 2013 17:18:00 -0000 [thread overview]
Message-ID: <52616D4B.3020209@redhat.com> (raw)
In-Reply-To: <5260FD66.7090506@broadcom.com>
On 10/18/2013 10:20 AM, Andrew Burgess wrote:
> While working on this:
> URL
:-)
> @@ -1946,8 +1946,13 @@ update_watchpoint (struct watchpoint *b, int reparse)
> }
> }
> else if (!b->base.ops->works_in_software_mode (&b->base))
> - error (_("Expression cannot be implemented with "
> - "read/access watchpoint."));
> + {
> + if (!can_use_hw_watchpoints)
> + error (_("Software read/access watchpoints not supported."));
Hmm, is this really "not supported", or rather "explicitly disabled"?
I think I'd prefer:
error (_("Hardware watchpoints support disabled. "
"See set/show can-use-hw-watchpoints."));
which also hints towards the toggle. WDYT?
--
Pedro Alves
next prev parent reply other threads:[~2013-10-18 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 9:20 Andrew Burgess
2013-10-18 17:18 ` Pedro Alves [this message]
2013-10-29 16:44 ` Andrew Burgess
2013-10-29 17:09 ` Pedro Alves
2013-10-29 17:19 ` Eli Zaretskii
2013-10-29 17:38 ` Andrew Burgess
2013-10-29 17:52 ` Pedro Alves
2013-10-29 19:09 ` Eli Zaretskii
2013-10-30 11:49 ` Andrew Burgess
2013-10-30 15:41 ` Eli Zaretskii
2013-10-30 17:13 ` Andrew Burgess
2013-10-30 18:41 ` Eli Zaretskii
2013-10-31 13:05 ` Andrew Burgess
2013-10-30 18:48 ` Pedro Alves
2013-10-30 19:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52616D4B.3020209@redhat.com \
--to=palves@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox