Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Extra error message from update_watchpoint
Date: Wed, 30 Oct 2013 18:48:00 -0000	[thread overview]
Message-ID: <52715484.4070409@redhat.com> (raw)
In-Reply-To: <52713E2F.2030709@broadcom.com>

On 10/30/2013 05:13 PM, Andrew Burgess wrote:
> "Can't set read/access watchpoint, software read/access watchpoints not
> supported, and hardware watchpoints disabled (see set/show
> can-use-hw-watchpoints)."

The mention of "software read/access watchpoints"
seems redundant to me.  IMO, the shorter:

 "Can't set read/access watchpoint with hardware watchpoint
 support disabled (see set/show can-use-hw-watchpoints)."

has all the info necessary.  WDYT?

If that's still too long, given that version says "disabled"
explicitly, then we might drop the "(see set/show
can-use-hw-watchpoints)" part.  (I don't see an issue with
using more than one line though.)

-- 
Pedro Alves


  parent reply	other threads:[~2013-10-30 18:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18  9:20 Andrew Burgess
2013-10-18 17:18 ` Pedro Alves
2013-10-29 16:44   ` Andrew Burgess
2013-10-29 17:09     ` Pedro Alves
2013-10-29 17:19     ` Eli Zaretskii
2013-10-29 17:38       ` Andrew Burgess
2013-10-29 17:52         ` Pedro Alves
2013-10-29 19:09           ` Eli Zaretskii
2013-10-30 11:49         ` Andrew Burgess
2013-10-30 15:41           ` Eli Zaretskii
2013-10-30 17:13             ` Andrew Burgess
2013-10-30 18:41               ` Eli Zaretskii
2013-10-31 13:05                 ` Andrew Burgess
2013-10-30 18:48               ` Pedro Alves [this message]
2013-10-30 19:19                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52715484.4070409@redhat.com \
    --to=palves@redhat.com \
    --cc=aburgess@broadcom.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox