From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3662 invoked by alias); 29 Oct 2013 17:19:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3640 invoked by uid 89); 29 Oct 2013 17:19:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout21.012.net.il Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Oct 2013 17:19:56 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MVF00100XG7BK00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Tue, 29 Oct 2013 19:19:54 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MVF0015MXH2BP00@a-mtaout21.012.net.il>; Tue, 29 Oct 2013 19:19:51 +0200 (IST) Date: Tue, 29 Oct 2013 17:19:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Extra error message from update_watchpoint In-reply-to: <526FE5E9.3000909@broadcom.com> To: Andrew Burgess Cc: gdb-patches@sourceware.org, palves@redhat.com Reply-to: Eli Zaretskii Message-id: <83ob68dmfb.fsf@gnu.org> References: <5260FD66.7090506@broadcom.com> <52616D4B.3020209@redhat.com> <526FE5E9.3000909@broadcom.com> X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00904.txt.bz2 > Date: Tue, 29 Oct 2013 16:44:25 +0000 > From: "Andrew Burgess" > cc: "Pedro Alves" > > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 608463d..68b348d 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -1805,7 +1805,8 @@ update_watchpoint (struct watchpoint *b, int reparse) > if (b->base.ops->works_in_software_mode (&b->base)) > b->base.type = bp_watchpoint; > else > - error (_("Software read/access watchpoints not supported.")); > + error (_("Hardware watchpoint support disabled. " > + "See set/show can-use-hw-watchpoints.")); Sorry for chiming in late, but IMO this change is a step backwards: the new warning is much more puzzling than the old one. The old one at least told what was the problem, the new one looks like entirely unrelated (unless you are privy to GDB internals). How about something like Cannot set read/access watchpoints without hardware watchpoint support.