Re: [PATCH 2/3] gdb, gdbserver, gdbsupport: include config.h files with -include

[Simon Marchi <simon.marchi@efficios.com>]

On 3/19/24 07:18, Hannes Domani wrote:
>  Am Montag, 18. März 2024 um 21:03:47 MEZ hat Simon Marchi <simon.marchi@efficios.com> Folgendes geschrieben:
> 
>> diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am
>> index 7c360aa413ef..db1eee88059a 100644
>> --- a/gdbsupport/Makefile.am
>> +++ b/gdbsupport/Makefile.am
>> @@ -35,6 +35,7 @@ AM_CPPFLAGS = \
>>      $(INCINTL) \
>>      -I../bfd \
>>      -I$(srcdir)/../bfd \
>> +    -include $(srcdir)/gdbsupport.inc.h \
>>      @LARGEFILE_CPPFLAGS@
>>
>> override CXX += $(CXX_DIALECT)
>> diff --git a/gdbsupport/Makefile.in b/gdbsupport/Makefile.in
>> index 6f8dacc157f9..9b1063f31ab3 100644
>> --- a/gdbsupport/Makefile.in
>> +++ b/gdbsupport/Makefile.in
>> @@ -393,10 +393,18 @@ ACLOCAL_AMFLAGS = -I . -I ../config
>> # from Automake, as gdbsupport uses AM_GNU_GETTEXT through
>> # ZW_GNU_GETTEXT_SISTER_DIR, but doesn't have any translations (currently).
>> SUBDIRS =
>> -AM_CPPFLAGS = -I$(srcdir)/../include -I$(srcdir)/../gdb \
>> -    -I../gnulib/import -I$(srcdir)/../gnulib/import \
>> -    -I.. -I$(srcdir)/.. $(INCINTL) -I../bfd -I$(srcdir)/../bfd \
>> -    @LARGEFILE_CPPFLAGS@
>> +AM_CPPFLAGS = \
>> +    -I$(srcdir)/../include \
>> +    -I$(srcdir)/../gdb \
>> +    -I../gnulib/import \
>> +    -I$(srcdir)/../gnulib/import \
>> +    -I.. \
>> +    -I$(srcdir)/.. \
>> +    $(INCINTL) \
>> +    -I../bfd \
>> +    -I$(srcdir)/../bfd \
>> +    -include $(srcdir)/gdbsupport.inc.h \
>> +    @LARGEFILE_CPPFLAGS@
>>
>> AM_CXXFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS)
>> noinst_LIBRARIES = libgdbsupport.a
> 
> Shouldn't most of this hunk be in the 'one entry per line' commit?

Ah yeah, I was missing regenerating gdbsupport/Makefile.in in the first
patch.  Fixed locally.  Thanks for pointing it out.

Simon