Re: [PATCH 2/3] gdb, gdbserver, gdbsupport: include config.h files with -include

[Pedro Alves <pedro@palves.net>]

On 2024-03-22 15:08, Simon Marchi wrote:
> On 3/22/24 10:55, Simon Marchi wrote:> Ack, thanks!
>>
>> Simon
> 
> One question: files such as gdb/arch/arc.c currently include
> gdbsupport/common-defs.h, since they are compiled separately in the gdb
> and gdbserver context.  With my changes (even when I'll update my patch
> to take the approach you suggest), the gdb-compiled version will use
> `-include defs.h`, while the gdbserver-compiled version will use
> `-include server.h`.  Both defs.h and server.h include common-defs.h, so
> it works.  But is it a problem?  Should I modify the build system so
> that these shared files use `-include gdbsupport/common-defs.h`?

I think we can go either way at this point, I don't think it's a real problem unless
we move the files to gdbsupport/.  Using common-defs.h helps a little with avoiding adding
gdb-only or gdbserver-only code, but then OTOH, some of the files under gdb/arch/ already have
conditional compilation with #ifdef GDBSERVER, unfortunately, so we're not ready to move them
somewhere where they're compiled once.

> 
> Another (more involved) option would be to see if these files could get
> moved to gdbsupport.

Yeah.