Re: [PATCH 2/3] gdb, gdbserver, gdbsupport: include config.h files with -include

[Simon Marchi <simark@simark.ca>]

On 3/22/24 10:55, Simon Marchi wrote:> Ack, thanks!
> 
> Simon

One question: files such as gdb/arch/arc.c currently include
gdbsupport/common-defs.h, since they are compiled separately in the gdb
and gdbserver context.  With my changes (even when I'll update my patch
to take the approach you suggest), the gdb-compiled version will use
`-include defs.h`, while the gdbserver-compiled version will use
`-include server.h`.  Both defs.h and server.h include common-defs.h, so
it works.  But is it a problem?  Should I modify the build system so
that these shared files use `-include gdbsupport/common-defs.h`?

Another (more involved) option would be to see if these files could get
moved to gdbsupport.

Simon