From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9RT0FCif/WXbpREAWB0awg (envelope-from ) for ; Fri, 22 Mar 2024 11:09:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1711120168; bh=uOeScPVuQW2Sf8z3Nwhw1EkX3y/fi1afd5/IXvDPGVw=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rSSaPEVKqNV+Zo11DpZ3FUWPAiidMZZIuUqe3x9enVhEowXgfzLElV+CaTgB+A1PD GoDuGNVAav4Tsl3RmdXwwHHU/M3WZupOpxeK3U+jLGnzFygPILu86wz9dOa9DltxlM vXMvDEgjQhISgztJpzpzG51wD8UgjQsJAYwzfD/o= Received: by simark.ca (Postfix, from userid 112) id 42FF61E0C0; Fri, 22 Mar 2024 11:09:28 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Gdv0FhOE; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2F76B1E030 for ; Fri, 22 Mar 2024 11:09:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1FB273858415 for ; Fri, 22 Mar 2024 15:09:25 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A55033858D28 for ; Fri, 22 Mar 2024 15:08:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A55033858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A55033858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711120147; cv=none; b=Y8+mYgU0vkr968hV7B30uMCloxJ4QALvSqvcv2uSDw/pwu8lGhxbqRM2rcn9E1sEAUsOMEdUKpK2pxy/Y+GLS9JN1sHBEPQv/QyALGUMF5R5udTp8OID2cypYDGsn0AlbRtgi0Cx15+lQ6wvws14t7rag5R3/J+K9iV2ngD9+iU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711120147; c=relaxed/simple; bh=uOeScPVuQW2Sf8z3Nwhw1EkX3y/fi1afd5/IXvDPGVw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cvMBaA3NFljkUrlU0YzFuguQVecywUWzulS+UByAl+3mRbovLnmfQNzJ2yODjqoSi1ILZojH416gy9u0/O2diYxWRRZ361fpXkVmHddhXHr9EuhgNsEprbYI/uQ0ecfIVquA8oG0uLo/I8dk2x74pfuh0yGQ+v+w8S1WaeD5ryg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1711120136; bh=uOeScPVuQW2Sf8z3Nwhw1EkX3y/fi1afd5/IXvDPGVw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Gdv0FhOEYoiN8yJm2Y5/uUxkDWKmdmcsK2wiZ7ah8I5+XXPvbUqcBcXzDLO8ZlmY+ nnu8ygt8DHlajOPHeTMmo3hrXC8p1wiA0sfTr9VqwYXfg4NP9O9tg/VK5VQcouAGjb zgDr6PwumMh+GbRm2hkf4QoyloWy3ot2v8SIN1lU= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 232FC1E030; Fri, 22 Mar 2024 11:08:56 -0400 (EDT) Message-ID: <13639831-3749-4d8d-83d1-dec2174320c0@simark.ca> Date: Fri, 22 Mar 2024 11:08:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] gdb, gdbserver, gdbsupport: include config.h files with -include To: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <20240318200257.131199-1-simon.marchi@efficios.com> <20240318200257.131199-2-simon.marchi@efficios.com> <2da78531-8a3a-4ac9-a87c-f4962d573fce@palves.net> <9a146cea-3adf-4365-8eb7-60c65d00dcf4@simark.ca> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/22/24 10:55, Simon Marchi wrote:> Ack, thanks! > > Simon One question: files such as gdb/arch/arc.c currently include gdbsupport/common-defs.h, since they are compiled separately in the gdb and gdbserver context. With my changes (even when I'll update my patch to take the approach you suggest), the gdb-compiled version will use `-include defs.h`, while the gdbserver-compiled version will use `-include server.h`. Both defs.h and server.h include common-defs.h, so it works. But is it a problem? Should I modify the build system so that these shared files use `-include gdbsupport/common-defs.h`? Another (more involved) option would be to see if these files could get moved to gdbsupport. Simon