Re: [PATCH 2/3] gdb, gdbserver, gdbsupport: include config.h files with -include

[Pedro Alves <pedro@palves.net>]

On 2024-03-21 12:50, Pedro Alves wrote:
> And at each step of the way, editing a header file always sees the exact
>  same set of pre-included files/symbols as when the same header
> is compiled normally.

Let me clarify this.  Here I was generally referring to the rule that source files should include their
module header right after defs.h.  Like:

 foo.c:
 #include "defs.h"
 #include "foo.h"
 * other includes *

So with that, there's one compilation unit that compiles "foo.h" exactly the same as what clangd sees when editing foo.h.

That even enforces "include what you need" in foo.h (other than the things defs.h already includes, of course).

We don't do that presently in many places, but we should do it throughout.  IIRC, Tromey even had a series to
normalize that throughout the tree a few years ago.  I don't recall why it didn't land.