From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 1/3] gdb, gdbserver, gdbsupport: reformat some Makefile variables, one entry per line
Date: Mon, 18 Mar 2024 16:01:38 -0400 [thread overview]
Message-ID: <20240318200257.131199-1-simon.marchi@efficios.com> (raw)
Reformat some variables that the subsequent patches are going to touch.
I think it makes them easier to read, and it also makes diffs clearer.
Change-Id: I82f63ba0e6d0fe268eb1f1ad5ab22c3cd016ab02
---
gdb/Makefile.in | 8 ++++++--
gdbserver/Makefile.in | 12 +++++++++---
gdbsupport/Makefile.am | 15 +++++++++++----
3 files changed, 26 insertions(+), 9 deletions(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 331620375aed..95709ae395a2 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -601,8 +601,12 @@ CONFIG_DEP_SUBDIR = $(addsuffix /$(DEPDIR),$(CONFIG_SRC_SUBDIR))
# your system doesn't have fcntl.h in /usr/include (which is where it
# should be according to Posix).
DEFS = @DEFS@
-GDB_CFLAGS = -I. -I$(srcdir) -I$(srcdir)/config \
- -DLOCALEDIR="\"$(localedir)\"" $(DEFS)
+GDB_CFLAGS = \
+ -I. \
+ -I$(srcdir) \
+ -I$(srcdir)/config \
+ -DLOCALEDIR="\"$(localedir)\"" \
+ $(DEFS)
# MH_CFLAGS, if defined, has host-dependent CFLAGS from the config directory.
GLOBAL_CFLAGS = $(MH_CFLAGS)
diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in
index c7120895a26d..c17a0a522df2 100644
--- a/gdbserver/Makefile.in
+++ b/gdbserver/Makefile.in
@@ -125,9 +125,15 @@ INCSUPPORT = -I$(srcdir)/.. -I..
# in those directories should be included with the subdirectory.
# e.g.: "target/wait.h".
#
-INCLUDE_CFLAGS = -I. -I${srcdir} \
- -I$(srcdir)/../gdb/regformats -I$(srcdir)/.. -I$(INCLUDE_DIR) \
- -I$(srcdir)/../gdb $(INCGNU) $(INCSUPPORT) \
+INCLUDE_CFLAGS = \
+ -I. \
+ -I${srcdir} \
+ -I$(srcdir)/../gdb/regformats \
+ -I$(srcdir)/.. \
+ -I$(INCLUDE_DIR) \
+ -I$(srcdir)/../gdb \
+ $(INCGNU) \
+ $(INCSUPPORT) \
$(INTL_CFLAGS)
# M{H,T}_CFLAGS, if defined, has host- and target-dependent CFLAGS
diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am
index 88414b4c927a..7c360aa413ef 100644
--- a/gdbsupport/Makefile.am
+++ b/gdbsupport/Makefile.am
@@ -25,10 +25,17 @@ ACLOCAL_AMFLAGS = -I . -I ../config
# ZW_GNU_GETTEXT_SISTER_DIR, but doesn't have any translations (currently).
SUBDIRS =
-AM_CPPFLAGS = -I$(srcdir)/../include -I$(srcdir)/../gdb \
- -I../gnulib/import -I$(srcdir)/../gnulib/import \
- -I.. -I$(srcdir)/.. $(INCINTL) -I../bfd -I$(srcdir)/../bfd \
- @LARGEFILE_CPPFLAGS@
+AM_CPPFLAGS = \
+ -I$(srcdir)/../include \
+ -I$(srcdir)/../gdb \
+ -I../gnulib/import \
+ -I$(srcdir)/../gnulib/import \
+ -I.. \
+ -I$(srcdir)/.. \
+ $(INCINTL) \
+ -I../bfd \
+ -I$(srcdir)/../bfd \
+ @LARGEFILE_CPPFLAGS@
override CXX += $(CXX_DIALECT)
base-commit: 0273b5967e21404d0442273b189b0e275cfafa74
--
2.44.0
next reply other threads:[~2024-03-18 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 20:01 Simon Marchi [this message]
2024-03-18 20:01 ` [PATCH 2/3] gdb, gdbserver, gdbsupport: include config.h files with -include Simon Marchi
2024-03-19 11:18 ` Hannes Domani
2024-03-19 12:22 ` Simon Marchi
2024-03-20 20:32 ` Pedro Alves
2024-03-21 2:11 ` Simon Marchi
2024-03-21 12:50 ` Pedro Alves
2024-03-21 13:02 ` Pedro Alves
2024-03-22 14:55 ` Simon Marchi
2024-03-22 15:08 ` Simon Marchi
2024-03-22 15:43 ` Pedro Alves
2024-03-18 20:01 ` [PATCH 3/3] gdbsupport: move more things to gdbsupport.inc.h Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318200257.131199-1-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox