From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Run7ApWD+WXMig0AWB0awg (envelope-from ) for ; Tue, 19 Mar 2024 08:22:45 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=E0L86Amj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EBC921E0BB; Tue, 19 Mar 2024 08:22:44 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C31F11E030 for ; Tue, 19 Mar 2024 08:22:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69B0E385841F for ; Tue, 19 Mar 2024 12:22:42 +0000 (GMT) Received: from YT3PR01CU008.outbound.protection.outlook.com (mail-canadacentralazon11020002.outbound.protection.outlook.com [52.101.189.2]) by sourceware.org (Postfix) with ESMTPS id 806283858CD1 for ; Tue, 19 Mar 2024 12:22:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 806283858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 806283858CD1 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.189.2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710850942; cv=pass; b=sYXA6/9QzXxiiPy3gkVG41NX48grFczcE0FkMoV71w70TxmVQmPat0kMEpJYKcq3YS1RJHa+o/Cr8oIa+tUzX5LlUou/+RUq25GPcNlrQmmr0OO8We0CSMVpLykELbuvrFYXBMGg22zzjh9qyrDyF6tLxChW3SBLToBgFdF/OmQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710850942; c=relaxed/simple; bh=Lr0F/SvmRqTfAmVZaW4aoAa/lrIyUsUqUW/bG6axBd8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=fb4lI9Fz75je/fLmBfXZ3j6uAEL5TVKxWgfV1QDA0faV0eeQsdsnTvHPKOffTszJqD+lqPqGdpHFqhoLWHBE3XdIdMUl9nlUXoz0/yeXeHm9soirgclo+OJ5NJYFQ1zEugAg4wHBwdMHEoH+E5TsM9wS5OeK4msdHoqh3+mWPsY= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HSbsFaLuIqmiy3pxwjGaBIAaAkgSwXtM2ecd3BWdtYGgw7oir8GzeSQpTwHjBcmT6nEPbwbpFDVY7zkrTv39kfSlxSF+vdy1BRE3qWY3bxcdQBAt6I1zltZI7kU2Ecbh11gc2y/BZ9irCEX6tLMwXNfQYM/iWzeY8X8VjDSdaHQj9qbS06ssefXD8PvblIEwHseuwKffmWVZDwb3IZJr8EsPglYWbOCg71pk0bc3ZvcVaHxLqLud3bYAY2AbDxexShM0zAjwVzvVv37t6ieQmIwMGnaYrMJjM+1r7rQH+Sj/9uXqDk1m9rp4P5FEE+cndGIn9pWOfIhurkt5t/zX2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cktu2DCUdDi4c35wjEhuSYqv2YmZWuexW80ODTZkF8I=; b=nnhit9XzDYJZweDd5MZuLW0I/XZZ9gYj/+vo0TsmlqlkcVseSfVNdQF5VEeTrFZQlVA7JGaSZRyDtCqfOqulcL6UnqOG7l1WC87UTur8GrNWdoLVBcGe9GsLMnKVUP28FKJHvk34VbkKsm4RI/OPaUb+dY93UeDc8l8eDuTf01IVZ56NZPZKlJoNJd0a0fKoQ4aKYNaPjYHulck8MK8m+IDc8Ek+8nN+h6ThxYRBe+NMmrLsNGJEijQ7DZ7F25eVrY8kWx9K0+E1ad3TSR2DYse4NJeECgr+swF/tfbBWlNeSnOaFJKcvVrXQ93GHwMII7CHEEPcGvF++lTSZXufYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cktu2DCUdDi4c35wjEhuSYqv2YmZWuexW80ODTZkF8I=; b=E0L86Amj09CRu+47p8x/6g8QgsbDDZoECtM9S6/iAqx7/X0QjaJW3a5zKikIX7eP4mVI2I54wypr5tfufXE6wYfTzFKZIvfFNcL/ibuywuGiOTPdmqtEo+TloBqlltRFWd26F2FTXIqnrSlOTHeLMEZQJVMJg6yXNMTQ0WAfhlh/V+lAj44Jw8bD/nn/eDF5XEUALr1WWgiJul0q9uXnjY2vtwV9/GOJCGRYqNDaUAHK4djeH4oOci4zT15opJh8ln6t2E1Hq4rgdgenFBaOmYUx6N8mzAAb3a9Updjo0nyKW2vy54I/O771Vb4utSE0t9C+U2VSm6q5/zEjCcmnOg== Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) by YT3PR01MB10462.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:76::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.12; Tue, 19 Mar 2024 12:22:18 +0000 Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1]) by YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1%5]) with mapi id 15.20.7409.009; Tue, 19 Mar 2024 12:22:18 +0000 Message-ID: <6d154262-d8c7-4bc3-9dda-b6a07d2d00b2@efficios.com> Date: Tue, 19 Mar 2024 08:22:17 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] gdb, gdbserver, gdbsupport: include config.h files with -include To: Hannes Domani , "gdb-patches@sourceware.org" References: <20240318200257.131199-1-simon.marchi@efficios.com> <20240318200257.131199-2-simon.marchi@efficios.com> <612462889.10028427.1710847098113@mail.yahoo.com> Content-Language: fr From: Simon Marchi In-Reply-To: <612462889.10028427.1710847098113@mail.yahoo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: YQZPR01CA0070.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:88::24) To YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5520:EE_|YT3PR01MB10462:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uq/ZkCw46td5oAM2iR7O4WlLkHkDR9oKjPi0v7KkEgZw1DN2fJzxLhgDytB/xXArHMmrPrcBqv1ydT+Ha6vtFQkT5uEvvkEiLasrJzypn1Yf/ZXKjDCMtPUjaUuSOXgLlfYDNpvQAIBhRGEYVyYSGLtT4PC84jWQCvfpO8MqyHyDqnxDU87bHaq30DGURj2OZ/VvqS8b5E9p/HMaeiRwLMkwmI8N7gk9ZCSRS/JPow+8SDng8+HZT/CbbVQuaRiGufIblDBnuZnvAH+B1dclqvZlc88xBVqryXczgie8dFnd8sv31KLcTl5gNiWJG5hv8zevbV4TITF/KjHs8STE8//ZLvtfMWxu2BG6suxmY9mjF5o+O21KZDfE8ZS6x7c7BSo+PaU38O5Rzpx7TwO1zjcqaSoUaaatUmGhOFEqA//1QGNKQnfG4a8nMQtjVWijHthScD0vvyrGVWnPMOkraNUVI3A9exZN6zbl58Rph4Ul8hBUovDhmhRHuKuVV/NMBgfrw9hZWQvkDpNl5xZdG/CvWmQjpMlDEWxzdq6wdOIN8KoZbf4q497IoJpYCDiwjwEFWtLuw1w5dfk8PCjYswLCidbpfp6PB92MWuDJsOVSLEHAr+ezMUfLUkefroqgd8D/zssJmo79sSerLhsD/oH+dRbt4hnR3MztfewjL5Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejlIYUNNNVFER0lPTjh0ZkliZGkvMmJWVnp1amluM2JENzFaelc4czhJc09u?= =?utf-8?B?V3JRUkVkMDlmR1Fvb0o5Mjg3djRJV2lwSW1sWWswb0RsOFN1ZVdvNHgvVnNl?= =?utf-8?B?T3lVQlZybXdWN043YXFrT1p4ZHJ1c1RRakdUaWZXWlVwTjZMN0IyQnVBdUZ6?= =?utf-8?B?Z2FJaVZndExEL3VTVHRBOTU5MzArdjZidU9sOUpadUd1dElvekYwMlRkYXEv?= =?utf-8?B?dHRlRHNBaTd1SEpHdmdsQmlkOWlJcFhxalNGY2l5SjF1cEFaNFpqN2pZYUlt?= =?utf-8?B?MHRSMHJlY0V6bWRnbjJURXZHTXRycDFzMnAySjZDNnY2SEQ3dWYyckJvWHFh?= =?utf-8?B?SkRVSzZtbXNHbEdrYmtsTXVyaEJEZmkycDkwUEZvcXh6S1dkS1kyVjdLSTlh?= =?utf-8?B?bnhHNSthN1ZrMDREV2lUY0RCZ09IdEYvZFBsOWVmazVKZjYyNEYxY0k4T2kx?= =?utf-8?B?Vy9jVjZGNlQrRHJ4RUp2eGZ1SzFZdEwrS1JSajBzdUkyZlNyOUhLSjlScGhB?= =?utf-8?B?Si9BNExvdG44YVh3Sm1pelJKSTgyQ1BoeHo5eDhnTFNZV3lSc0liK0Q1VkFl?= =?utf-8?B?V1l4Q2tzR0tER3hQMEMrbmUzcm54TTIzV2FKVThPZVN4V2twVEd5L0p5cHha?= =?utf-8?B?VFRnM0dQZ3AzY01lT3pkdWdhSXlxRnBjcWNwRFFucjljRDNFMlR1QkRJQTJT?= =?utf-8?B?dnJMTW5BSVlIcHNTQTUzSlBxbVUrRUMvWFlGWEw4MEFPQ0UwekZJYmROWVlh?= =?utf-8?B?d0syVjBxYWtxSWxpT09WT25zWHlsb3NGcXRkbklHSXpnYXhSZFpFN1UyclJX?= =?utf-8?B?TXBPTjNSRG14MDh2R0lFemxFMi8ya0o3eFRqK0JLcVpDbWlGZEpZa3hKdjQ0?= =?utf-8?B?TCtadDR5MnFYdkt0SmFseE1hekpaUmpPbXpCaEErWUZ2K2xJaFlVcEJwbHBt?= =?utf-8?B?NzMrMVdVSDQyamxoSW5KdkhFNkt3Rm9UZXNVY3d2aXRsUVovYXM4YmhodEVT?= =?utf-8?B?WkZHTEkwcnU1eUZMOGlHdVUrSnJUTTFDQmIvanZDbU1aUy9yWFJMWXpxdTdx?= =?utf-8?B?T3o2eGFlVEpSdU1oS2RWODhXRkdQOSsxaE9sbnZmUnJwZEJKcWFTOTR2Q1Y0?= =?utf-8?B?SHFURHRIbW5qN3djdU5FRzl1RXgwWlpCMmMyRSthdG9oUUpnU2NuOGxiaXhu?= =?utf-8?B?TnpLZmxQTVNxUUFvWGZIVUlSaEkrM2xROStORTV3QkRDM2FzSEl6TFFJaVda?= =?utf-8?B?MTJkWFFaWE5KcnFpYk9wQmxKMGRjL0FyZXQ0eXZORVVnaXFpN05GcFh5RGY0?= =?utf-8?B?T1BYVStXZlJKRmlTcUhUL2J6SzVKS20xMVI5ajVpZXlqdUw5STNGZFpWVnVH?= =?utf-8?B?ZGR2aGR1WjZoVFN3T0tjZWpTNUNtcDNWSG9zcUY2aXZDWkIwa21GU0FhS1hS?= =?utf-8?B?aXo5a3pIQVREREZjNlFmY1F0VVY3OC9QNUU0aUdQcXIwSUpwK2tORVVLNFFN?= =?utf-8?B?RCthbjVDLytKamN1ZTFodVdIM1MwVnpSakplSjNxRHppMCtQZkxKeWlMMGNB?= =?utf-8?B?aUk5YXpqcERNQ3hFcisxWXNTT3I3cU1meHdnQ2hjSDVOM0JOMHZ2a2JrS0Fu?= =?utf-8?B?SDZZMmJuYWJMK3g0VCtxTmRhenhtdmxGdnMzdmNiVE81WXJZUHcwQ093ODla?= =?utf-8?B?Zis1Rnd4ZUp5ck1hOXZHWW4vZk00cWJmbHVFMWwxYjVsNmQ1dWtUaUsvQzNB?= =?utf-8?B?dTNXblV6Z1BlOTJPNTZ6NElCaEkwQVY3a0tRdU9LWnkxbkNNdDN4aVVQWXNh?= =?utf-8?B?OWY5UkZXcGVYTDZvcDIzTnd3aXZqdnJNYmFOd1hzMGlDcVBGMUo0WVlabk1G?= =?utf-8?B?dzR1OHpZVjZKYU5NZmFsUk1HYWpJMng3ZHdNZk1udjNQdHE3SWVRamVYNFVk?= =?utf-8?B?QTVkaUxXeVFTNTVWZU9lK09sd0M4MWZvNUFBK1hMdWgrcVZTam1tREtJWlpl?= =?utf-8?B?cGlRZEpvT1RoMGwxaGNMMzhGRzNhVk1wdHRVSk5QUlpyRjlvTmJHUlpmVUhj?= =?utf-8?B?OGdKbXlxMUtJTEhwRnFNVld1WjJQdjFrRWFFUG0wQ0s3dnFCYkNvOXZZQ2JJ?= =?utf-8?Q?ePtFdWTwvySnoxhMEN7yt2fg6?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1f9a9c3-aae1-4786-f94b-08dc480f384e X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 12:22:18.8283 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SLdZvH06/HBbzsS1X/bWhzrnkI2ou+ruhCUzL+kP9ZqpjZsHgTF7nq3U7gSkwVoA9L1w9wh00RwP4157aOsNFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB10462 X-Spam-Status: No, score=-3038.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/19/24 07:18, Hannes Domani wrote: > Am Montag, 18. März 2024 um 21:03:47 MEZ hat Simon Marchi Folgendes geschrieben: > >> diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am >> index 7c360aa413ef..db1eee88059a 100644 >> --- a/gdbsupport/Makefile.am >> +++ b/gdbsupport/Makefile.am >> @@ -35,6 +35,7 @@ AM_CPPFLAGS = \ >> $(INCINTL) \ >> -I../bfd \ >> -I$(srcdir)/../bfd \ >> + -include $(srcdir)/gdbsupport.inc.h \ >> @LARGEFILE_CPPFLAGS@ >> >> override CXX += $(CXX_DIALECT) >> diff --git a/gdbsupport/Makefile.in b/gdbsupport/Makefile.in >> index 6f8dacc157f9..9b1063f31ab3 100644 >> --- a/gdbsupport/Makefile.in >> +++ b/gdbsupport/Makefile.in >> @@ -393,10 +393,18 @@ ACLOCAL_AMFLAGS = -I . -I ../config >> # from Automake, as gdbsupport uses AM_GNU_GETTEXT through >> # ZW_GNU_GETTEXT_SISTER_DIR, but doesn't have any translations (currently). >> SUBDIRS = >> -AM_CPPFLAGS = -I$(srcdir)/../include -I$(srcdir)/../gdb \ >> - -I../gnulib/import -I$(srcdir)/../gnulib/import \ >> - -I.. -I$(srcdir)/.. $(INCINTL) -I../bfd -I$(srcdir)/../bfd \ >> - @LARGEFILE_CPPFLAGS@ >> +AM_CPPFLAGS = \ >> + -I$(srcdir)/../include \ >> + -I$(srcdir)/../gdb \ >> + -I../gnulib/import \ >> + -I$(srcdir)/../gnulib/import \ >> + -I.. \ >> + -I$(srcdir)/.. \ >> + $(INCINTL) \ >> + -I../bfd \ >> + -I$(srcdir)/../bfd \ >> + -include $(srcdir)/gdbsupport.inc.h \ >> + @LARGEFILE_CPPFLAGS@ >> >> AM_CXXFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS) >> noinst_LIBRARIES = libgdbsupport.a > > Shouldn't most of this hunk be in the 'one entry per line' commit? Ah yeah, I was missing regenerating gdbsupport/Makefile.in in the first patch. Fixed locally. Thanks for pointing it out. Simon