Re: [PATCH v3 1/5] gdb: make the remote target track its own thread resume state

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-01-08 10:41 a.m., Pedro Alves wrote:
> Hi,
> 
> This patch LGTM.  A couple tiny issue below.
> 
>> gdb/ChangeLog:
>>
>>         * remote.c (enum class resume_state): New.
>>         (struct resumed_pending_vcont_info): New.
>>         (struct remote_thread_info) <resume_state, set_not_resumed,
>> 	set_resumed_pending_vcont, resumed_pending_vcont_info,
>> 	set_resumed, m_resume_state, m_resumed_pending_vcont_info>:
>> 	New.
>> 	<last_resume_step, last_resume_sig, vcont_resumed>: Remove.
>>         (remote_target::remote_add_thread): Adjust.
>>         (remote_target::process_initial_stop_replies): Adjust.
>>         (remote_target::resume): Adjust.
>>         (remote_target::commit_resume): Rely on state in
>> 	remote_thread_info and not on tp->executing.
>>         (remote_target::process_stop_reply): Adjust.
> 
> Mind spaces vs tabs in the ChangeLog entry.

Fixed.

> 
>> +/* Information about a thread's pending vCont-resume.  Used when a thread is in
>> +   the remote_resume_state::RESUMED_PENDING_VCONT state.  remote_target::resume
>> +   stores this information which is them picked up by
> 
> them -> then

Fixed.

> That's it.  :-)

Thanks!

Simon