Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH v3 2/5] gdb: remove target_ops::commit_resume implementation in record-{btrace, full}.c
Date: Thu,  7 Jan 2021 23:17:31 -0500	[thread overview]
Message-ID: <20210108041734.3873826-3-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20210108041734.3873826-1-simon.marchi@polymtl.ca>

From: Simon Marchi <simon.marchi@efficios.com>

The previous patch made the commit_resume implementations in the record
targets unnecessary, as the remote target's commit_resume implementation
won't commit-resume threads for which it didn't see a resume.  This
patch removes them.

gdb/ChangeLog:

        * record-btrace.c (class record_btrace_target):
        (record_btrace_target::commit_resume):
        * record-full.c (class record_full_target):
        (record_full_target::commit_resume):

Change-Id: I3a68d3d726fb09d8b7165b4edefc330d27803b27
---
 gdb/record-btrace.c | 11 -----------
 gdb/record-full.c   | 10 ----------
 2 files changed, 21 deletions(-)

diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
index 5924e83898a0..81686ee867b7 100644
--- a/gdb/record-btrace.c
+++ b/gdb/record-btrace.c
@@ -116,7 +116,6 @@ class record_btrace_target final : public target_ops
 
   const struct frame_unwind *get_tailcall_unwinder () override;
 
-  void commit_resume () override;
   void resume (ptid_t, int, enum gdb_signal) override;
   ptid_t wait (ptid_t, struct target_waitstatus *, target_wait_flags) override;
 
@@ -2206,16 +2205,6 @@ record_btrace_target::resume (ptid_t ptid, int step, enum gdb_signal signal)
     }
 }
 
-/* The commit_resume method of target record-btrace.  */
-
-void
-record_btrace_target::commit_resume ()
-{
-  if ((::execution_direction != EXEC_REVERSE)
-      && !record_is_replaying (minus_one_ptid))
-    beneath ()->commit_resume ();
-}
-
 /* Cancel resuming TP.  */
 
 static void
diff --git a/gdb/record-full.c b/gdb/record-full.c
index 5ed9c1a428b1..22eaaa4bb1bc 100644
--- a/gdb/record-full.c
+++ b/gdb/record-full.c
@@ -267,7 +267,6 @@ class record_full_target final : public record_full_base_target
   const target_info &info () const override
   { return record_full_target_info; }
 
-  void commit_resume () override;
   void resume (ptid_t, int, enum gdb_signal) override;
   void disconnect (const char *, int) override;
   void detach (inferior *, int) override;
@@ -1103,15 +1102,6 @@ record_full_target::resume (ptid_t ptid, int step, enum gdb_signal signal)
     target_async (1);
 }
 
-/* "commit_resume" method for process record target.  */
-
-void
-record_full_target::commit_resume ()
-{
-  if (!RECORD_FULL_IS_REPLAY)
-    beneath ()->commit_resume ();
-}
-
 static int record_full_get_sig = 0;
 
 /* SIGINT signal handler, registered by "wait" method.  */
-- 
2.29.2


  parent reply	other threads:[~2021-01-08  4:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08  4:17 [PATCH v3 0/5] Reduce back and forth with target when threads have pending statuses + better handling of 'S' packets Simon Marchi via Gdb-patches
2021-01-08  4:17 ` [PATCH v3 1/5] gdb: make the remote target track its own thread resume state Simon Marchi via Gdb-patches
2021-01-08 15:41   ` Pedro Alves
2021-01-08 18:56     ` Simon Marchi via Gdb-patches
2021-01-18  5:16   ` Sebastian Huber
2021-01-18  6:04     ` Simon Marchi via Gdb-patches
2021-01-18 10:36       ` Sebastian Huber
2021-01-18 13:53         ` Simon Marchi via Gdb-patches
2021-01-08  4:17 ` Simon Marchi via Gdb-patches [this message]
2021-01-08 15:43   ` [PATCH v3 2/5] gdb: remove target_ops::commit_resume implementation in record-{btrace,full}.c Pedro Alves
2021-01-08 19:00     ` Simon Marchi via Gdb-patches
2021-01-08  4:17 ` [PATCH v3 3/5] gdb: move commit_resume to process_stratum_target Simon Marchi via Gdb-patches
2021-01-08 18:12   ` Andrew Burgess
2021-01-08 19:01     ` Simon Marchi via Gdb-patches
2021-01-09 20:29   ` Pedro Alves
2021-01-08  4:17 ` [PATCH v3 4/5] gdb: generalize commit_resume, avoid commit-resuming when threads have pending statuses Simon Marchi via Gdb-patches
2021-01-08 18:34   ` Andrew Burgess
2021-01-08 19:04     ` Simon Marchi via Gdb-patches
2021-01-09 20:34   ` Pedro Alves
2021-01-11 20:28     ` Simon Marchi via Gdb-patches
2021-01-22  2:46       ` Simon Marchi via Gdb-patches
2021-01-22 22:07       ` Simon Marchi via Gdb-patches
2021-01-12 17:14   ` Simon Marchi via Gdb-patches
2021-01-12 18:04     ` Simon Marchi via Gdb-patches
2021-01-15 19:17   ` Simon Marchi via Gdb-patches
2021-01-08  4:17 ` [PATCH v3 5/5] gdb: better handling of 'S' packets Simon Marchi via Gdb-patches
2021-01-08 18:19   ` Andrew Burgess
2021-01-08 19:11     ` Simon Marchi via Gdb-patches
2021-01-09 21:26   ` Pedro Alves
2021-01-11 20:36     ` Simon Marchi via Gdb-patches
2021-01-12  3:07       ` Simon Marchi via Gdb-patches
2021-01-13 20:17         ` Pedro Alves
2021-01-14  1:28           ` Simon Marchi via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108041734.3873826-3-simon.marchi@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox