From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cEJbAebc919dIAAAWB0awg (envelope-from ) for ; Thu, 07 Jan 2021 23:17:42 -0500 Received: by simark.ca (Postfix, from userid 112) id F3AE71EE17; Thu, 7 Jan 2021 23:17:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 97F761E519; Thu, 7 Jan 2021 23:17:40 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EF8A43971C35; Fri, 8 Jan 2021 04:17:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF8A43971C35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610079460; bh=tBu+2WvxcStmidUJh/amrsCfMyemhweST2k9JhjWgNo=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QuRv0Jwrk7cpoa7fxDL8fO+9CcTLJnJrdZ4xISs164nwp3NREUYertYyVLpq6c42i WMX3m3nxpP7IZr0kQShI4fqIsexcqMcQ8L4en339i7JUcjqi3OuiSpv9Hz5+Gc9GxE rPLzMZV8wLyMioCGIAb4x85rpbN5tmnZYrXGhBhw= Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id 19B9C3971C2E for ; Fri, 8 Jan 2021 04:17:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 19B9C3971C2E X-ASG-Debug-ID: 1610079455-0c856e6cd564ae20001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id D7ndiAot028zNCRy (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 07 Jan 2021 23:17:35 -0500 (EST) X-Barracuda-Envelope-From: simon.marchi@polymtl.ca X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from simark.localdomain (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) by smtp.ebox.ca (Postfix) with ESMTP id 6A400441D65; Thu, 7 Jan 2021 23:17:35 -0500 (EST) X-Barracuda-RBL-IP: 192.222.157.6 X-Barracuda-Effective-Source-IP: 192-222-157-6.qc.cable.ebox.net[192.222.157.6] X-Barracuda-Apparent-Source-IP: 192.222.157.6 To: gdb-patches@sourceware.org Subject: [PATCH v3 2/5] gdb: remove target_ops::commit_resume implementation in record-{btrace, full}.c Date: Thu, 7 Jan 2021 23:17:31 -0500 X-ASG-Orig-Subj: [PATCH v3 2/5] gdb: remove target_ops::commit_resume implementation in record-{btrace, full}.c Message-Id: <20210108041734.3873826-3-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210108041734.3873826-1-simon.marchi@polymtl.ca> References: <20210108041734.3873826-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1610079455 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-Scan-Msg-Size: 2516 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.87085 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" From: Simon Marchi The previous patch made the commit_resume implementations in the record targets unnecessary, as the remote target's commit_resume implementation won't commit-resume threads for which it didn't see a resume. This patch removes them. gdb/ChangeLog: * record-btrace.c (class record_btrace_target): (record_btrace_target::commit_resume): * record-full.c (class record_full_target): (record_full_target::commit_resume): Change-Id: I3a68d3d726fb09d8b7165b4edefc330d27803b27 --- gdb/record-btrace.c | 11 ----------- gdb/record-full.c | 10 ---------- 2 files changed, 21 deletions(-) diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index 5924e83898a0..81686ee867b7 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -116,7 +116,6 @@ class record_btrace_target final : public target_ops const struct frame_unwind *get_tailcall_unwinder () override; - void commit_resume () override; void resume (ptid_t, int, enum gdb_signal) override; ptid_t wait (ptid_t, struct target_waitstatus *, target_wait_flags) override; @@ -2206,16 +2205,6 @@ record_btrace_target::resume (ptid_t ptid, int step, enum gdb_signal signal) } } -/* The commit_resume method of target record-btrace. */ - -void -record_btrace_target::commit_resume () -{ - if ((::execution_direction != EXEC_REVERSE) - && !record_is_replaying (minus_one_ptid)) - beneath ()->commit_resume (); -} - /* Cancel resuming TP. */ static void diff --git a/gdb/record-full.c b/gdb/record-full.c index 5ed9c1a428b1..22eaaa4bb1bc 100644 --- a/gdb/record-full.c +++ b/gdb/record-full.c @@ -267,7 +267,6 @@ class record_full_target final : public record_full_base_target const target_info &info () const override { return record_full_target_info; } - void commit_resume () override; void resume (ptid_t, int, enum gdb_signal) override; void disconnect (const char *, int) override; void detach (inferior *, int) override; @@ -1103,15 +1102,6 @@ record_full_target::resume (ptid_t ptid, int step, enum gdb_signal signal) target_async (1); } -/* "commit_resume" method for process record target. */ - -void -record_full_target::commit_resume () -{ - if (!RECORD_FULL_IS_REPLAY) - beneath ()->commit_resume (); -} - static int record_full_get_sig = 0; /* SIGINT signal handler, registered by "wait" method. */ -- 2.29.2