From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH v3 2/5] gdb: remove target_ops::commit_resume implementation in record-{btrace,full}.c
Date: Fri, 8 Jan 2021 14:00:18 -0500 [thread overview]
Message-ID: <2d0a9fb8-b507-b7a2-92ab-e3452b1db04e@polymtl.ca> (raw)
In-Reply-To: <f77f8e2e-abbc-f5c3-2d5f-9848e530920b@palves.net>
On 2021-01-08 10:43 a.m., Pedro Alves wrote:
> On 08/01/21 04:17, Simon Marchi wrote:
>> From: Simon Marchi <simon.marchi@efficios.com>
>>
>> The previous patch made the commit_resume implementations in the record
>> targets unnecessary, as the remote target's commit_resume implementation
>> won't commit-resume threads for which it didn't see a resume. This
>> patch removes them.
>>
>> gdb/ChangeLog:
>>
>> * record-btrace.c (class record_btrace_target):
>> (record_btrace_target::commit_resume):
>> * record-full.c (class record_full_target):
>> (record_full_target::commit_resume):
>
> Incomplete entry.
Woops, fixed. It's "Remove." everywhere.
> Otherwise LGTM. I like how these two patches result in clearer code. Nice.
Ok, thanks. I'll keep reading the comments to see where the rest of the series
is going, but in any case I think we can at least push patches 1 and 2 on their
own then, if they are a good clean up on their own.
Simon
next prev parent reply other threads:[~2021-01-08 19:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 4:17 [PATCH v3 0/5] Reduce back and forth with target when threads have pending statuses + better handling of 'S' packets Simon Marchi via Gdb-patches
2021-01-08 4:17 ` [PATCH v3 1/5] gdb: make the remote target track its own thread resume state Simon Marchi via Gdb-patches
2021-01-08 15:41 ` Pedro Alves
2021-01-08 18:56 ` Simon Marchi via Gdb-patches
2021-01-18 5:16 ` Sebastian Huber
2021-01-18 6:04 ` Simon Marchi via Gdb-patches
2021-01-18 10:36 ` Sebastian Huber
2021-01-18 13:53 ` Simon Marchi via Gdb-patches
2021-01-08 4:17 ` [PATCH v3 2/5] gdb: remove target_ops::commit_resume implementation in record-{btrace, full}.c Simon Marchi via Gdb-patches
2021-01-08 15:43 ` [PATCH v3 2/5] gdb: remove target_ops::commit_resume implementation in record-{btrace,full}.c Pedro Alves
2021-01-08 19:00 ` Simon Marchi via Gdb-patches [this message]
2021-01-08 4:17 ` [PATCH v3 3/5] gdb: move commit_resume to process_stratum_target Simon Marchi via Gdb-patches
2021-01-08 18:12 ` Andrew Burgess
2021-01-08 19:01 ` Simon Marchi via Gdb-patches
2021-01-09 20:29 ` Pedro Alves
2021-01-08 4:17 ` [PATCH v3 4/5] gdb: generalize commit_resume, avoid commit-resuming when threads have pending statuses Simon Marchi via Gdb-patches
2021-01-08 18:34 ` Andrew Burgess
2021-01-08 19:04 ` Simon Marchi via Gdb-patches
2021-01-09 20:34 ` Pedro Alves
2021-01-11 20:28 ` Simon Marchi via Gdb-patches
2021-01-22 2:46 ` Simon Marchi via Gdb-patches
2021-01-22 22:07 ` Simon Marchi via Gdb-patches
2021-01-12 17:14 ` Simon Marchi via Gdb-patches
2021-01-12 18:04 ` Simon Marchi via Gdb-patches
2021-01-15 19:17 ` Simon Marchi via Gdb-patches
2021-01-08 4:17 ` [PATCH v3 5/5] gdb: better handling of 'S' packets Simon Marchi via Gdb-patches
2021-01-08 18:19 ` Andrew Burgess
2021-01-08 19:11 ` Simon Marchi via Gdb-patches
2021-01-09 21:26 ` Pedro Alves
2021-01-11 20:36 ` Simon Marchi via Gdb-patches
2021-01-12 3:07 ` Simon Marchi via Gdb-patches
2021-01-13 20:17 ` Pedro Alves
2021-01-14 1:28 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d0a9fb8-b507-b7a2-92ab-e3452b1db04e@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox