From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jEVaIwOr+F/vNgAAWB0awg (envelope-from ) for ; Fri, 08 Jan 2021 13:57:07 -0500 Received: by simark.ca (Postfix, from userid 112) id 810DE1E99A; Fri, 8 Jan 2021 13:57:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2EF4A1E590 for ; Fri, 8 Jan 2021 13:57:07 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D159338438A3; Fri, 8 Jan 2021 18:57:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D159338438A3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610132226; bh=dnuxcR6XHBdU8Mpbj3vncedYu+7XWJesKijFlh3Hxu8=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=g1YT8HfBkZFXm/J2jfdJABBkOqy18T5lEJbm5Zz6wtWBe9aLY4hedEeaOT+XrciA9 XB4KcHJ0bfjR0fES+0yGzlVCAHin81K1/Qe2KIBEXx0TsthHvUhBKCsS/a+YGQny8q 3aVou6vFXXzRMrGqwe/u4Yu2lWgysPTYphYDLfsg= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id AB8DA38438A3 for ; Fri, 8 Jan 2021 18:57:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AB8DA38438A3 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 108Iut3K025694 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Jan 2021 13:57:00 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 108Iut3K025694 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 845871E590; Fri, 8 Jan 2021 13:56:55 -0500 (EST) Subject: Re: [PATCH v3 1/5] gdb: make the remote target track its own thread resume state To: Pedro Alves , gdb-patches@sourceware.org References: <20210108041734.3873826-1-simon.marchi@polymtl.ca> <20210108041734.3873826-2-simon.marchi@polymtl.ca> <40239345-48c3-1015-7ee3-e80489ccdce6@palves.net> Message-ID: <6b6cac1d-1aab-ffc7-dccd-15d69be72f91@polymtl.ca> Date: Fri, 8 Jan 2021 13:56:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <40239345-48c3-1015-7ee3-e80489ccdce6@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 8 Jan 2021 18:56:55 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-08 10:41 a.m., Pedro Alves wrote: > Hi, > > This patch LGTM. A couple tiny issue below. > >> gdb/ChangeLog: >> >> * remote.c (enum class resume_state): New. >> (struct resumed_pending_vcont_info): New. >> (struct remote_thread_info) > set_resumed_pending_vcont, resumed_pending_vcont_info, >> set_resumed, m_resume_state, m_resumed_pending_vcont_info>: >> New. >> : Remove. >> (remote_target::remote_add_thread): Adjust. >> (remote_target::process_initial_stop_replies): Adjust. >> (remote_target::resume): Adjust. >> (remote_target::commit_resume): Rely on state in >> remote_thread_info and not on tp->executing. >> (remote_target::process_stop_reply): Adjust. > > Mind spaces vs tabs in the ChangeLog entry. Fixed. > >> +/* Information about a thread's pending vCont-resume. Used when a thread is in >> + the remote_resume_state::RESUMED_PENDING_VCONT state. remote_target::resume >> + stores this information which is them picked up by > > them -> then Fixed. > That's it. :-) Thanks! Simon