From: Keith Seitz <keiths@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "Agovic, Sanimir" <sanimir.agovic@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v6 00/15] Please have a final look
Date: Fri, 11 Apr 2014 20:33:00 -0000 [thread overview]
Message-ID: <5348518D.8010100@redhat.com> (raw)
In-Reply-To: <20140411202747.GN4250@adacore.com>
On 04/11/2014 01:27 PM, Joel Brobecker wrote:
>>> Thank you Joel for helping me out through the patch series! I just
>>> committed the patches including the final adjustments.
>>
>> Unfortunatley, this patchset has regressed the following tests:
>
> Argh! Sorry about that, and thanks for the heads up, Keith.
>
Not a problem -- I was just about to commit some patches -- one of which
touches some bits of this patch set and noticed that a clean update/test
had a few more FAILs than I expected. [We all keep a mental count of the
"normal" number of FAILs on our systems, right? ;-)]
> I'm doing a quick round of testing with what's left of my day today,
> but we might have to revert the patch series to allow us more time
> to investigate.
Would you like me to hold off on committing my c++/16675 patchset? That
touches eval.c:evaluate_subexp_for_sizeof. It's not a huge deal IMO. A
Most of the "conflict" is simply that I chose to refactor this function
a little. [i.e., remove all the "return value_from_longest" and collect
them at the end of the function]
> How come this didn't show up in Sanimir's testing?
I don't know. Maybe my sandbox is messed up? It *is* Friday afterall! :-)
Keith
next prev parent reply other threads:[~2014-04-11 20:33 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 12:42 Sanimir Agovic
2014-04-10 12:42 ` [PATCH v6 01/15] refactoring: rename create_range_type to create_static_range_type Sanimir Agovic
2014-04-10 12:43 ` [PATCH v6 02/15] vla: introduce new bound type abstraction adapt uses Sanimir Agovic
2014-04-10 12:44 ` [PATCH v6 04/15] vla: enable sizeof operator to work with variable length arrays Sanimir Agovic
2014-04-10 12:44 ` [PATCH v6 03/15] type: add c99 variable length array support Sanimir Agovic
2014-04-10 14:21 ` Joel Brobecker
2014-04-10 12:45 ` [PATCH v6 05/15] vla: enable sizeof operator for indirection Sanimir Agovic
2014-04-10 12:46 ` [PATCH v6 06/15] vla: update type from newly created value Sanimir Agovic
2014-04-10 12:47 ` [PATCH v6 07/15] vla: print "variable length" for unresolved dynamic bounds Sanimir Agovic
2014-04-10 12:48 ` [PATCH v6 09/15] vla: resolve dynamic bounds if value contents is a constant byte-sequence Sanimir Agovic
2014-04-10 14:22 ` Joel Brobecker
2014-04-10 12:48 ` [PATCH v6 08/15] vla: support for DW_AT_count Sanimir Agovic
2014-04-10 12:49 ` [PATCH v6 11/15] test: cover subranges with present DW_AT_count attribute Sanimir Agovic
2014-04-10 12:49 ` [PATCH v6 10/15] vla: evaluate operand of sizeof if its type is a vla Sanimir Agovic
2014-04-10 14:31 ` Joel Brobecker
2014-04-10 12:50 ` [PATCH v6 12/15] test: multi-dimensional c99 vla Sanimir Agovic
2014-04-10 12:51 ` [PATCH v6 13/15] test: evaluate pointers to C99 vla correctly Sanimir Agovic
2014-04-10 12:52 ` [PATCH v6 14/15] test: basic c99 vla tests for C primitives Sanimir Agovic
2014-04-10 12:53 ` [PATCH v6 15/15] test: add mi vla test Sanimir Agovic
2014-04-10 14:39 ` [PATCH v6 00/15] Please have a final look Joel Brobecker
2014-04-10 14:46 ` Joel Brobecker
2014-04-22 15:33 ` Agovic, Sanimir
2014-04-22 16:58 ` Eli Zaretskii
2014-04-11 12:50 ` Agovic, Sanimir
2014-04-11 20:03 ` Keith Seitz
2014-04-11 20:27 ` Joel Brobecker
2014-04-11 20:33 ` Keith Seitz [this message]
2014-04-11 21:13 ` Joel Brobecker
2014-04-11 21:19 ` Keith Seitz
2014-04-11 22:33 ` Joel Brobecker
2014-04-14 8:34 ` Agovic, Sanimir
2014-04-14 17:13 ` [vla v7 pushed] " Joel Brobecker
2014-04-14 17:13 ` [PATCH 06/12] vla: support for DW_AT_count Joel Brobecker
2014-04-14 17:13 ` [PATCH 08/12] vla: evaluate operand of sizeof if its type is a vla Joel Brobecker
2014-04-14 17:13 ` [PATCH 01/12] type: add c99 variable length array support Joel Brobecker
2014-04-18 19:06 ` Joel Brobecker
2014-04-14 17:13 ` [PATCH 02/12] vla: enable sizeof operator to work with variable length arrays Joel Brobecker
2014-04-14 17:13 ` [PATCH 07/12] vla: resolve dynamic bounds if value contents is a constant byte-sequence Joel Brobecker
2014-04-14 17:13 ` [PATCH 04/12] vla: update type from newly created value Joel Brobecker
2014-04-14 17:13 ` [PATCH 03/12] vla: enable sizeof operator for indirection Joel Brobecker
2014-04-14 17:13 ` [PATCH 05/12] vla: print "variable length" for unresolved dynamic bounds Joel Brobecker
2014-04-14 17:14 ` [PATCH 12/12] test: add mi vla test Joel Brobecker
2014-04-14 17:14 ` [PATCH 09/12] test: cover subranges with present DW_AT_count attribute Joel Brobecker
2014-04-14 17:14 ` [PATCH 11/12] test: basic c99 vla tests for C primitives Joel Brobecker
2014-04-14 17:14 ` [PATCH 10/12] test: evaluate pointers to C99 vla correctly Joel Brobecker
2014-04-14 17:36 ` [vla v7 pushed] Re: [PATCH v6 00/15] Please have a final look Agovic, Sanimir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5348518D.8010100@redhat.com \
--to=keiths@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=sanimir.agovic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox