From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Sanimir Agovic <sanimir.agovic@intel.com>
Subject: [PATCH 03/12] vla: enable sizeof operator for indirection
Date: Mon, 14 Apr 2014 17:13:00 -0000 [thread overview]
Message-ID: <1397495596-25364-4-git-send-email-brobecker@adacore.com> (raw)
In-Reply-To: <1397495596-25364-1-git-send-email-brobecker@adacore.com>
From: Sanimir Agovic <sanimir.agovic@intel.com>
This patch enables the sizeof operator for indirections:
1| void foo (size_t n) {
2| int vla[n];
3| int *vla_ptr = &vla;
4| }
(gdb) p sizeof(*vla_ptr)
yields sizeof (size_t) * n.
gdb/ChangeLog:
* eval.c (evaluate_subexp_for_sizeof) <UNOP_IND>: Create an indirect
value and retrieve the dynamic type size.
---
gdb/ChangeLog | 5 +++++
gdb/eval.c | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1755609..c7efe62 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2014-04-14 Sanimir Agovic <sanimir.agovic@intel.com>
+ * eval.c (evaluate_subexp_for_sizeof) <UNOP_IND>: Create an indirect
+ value and retrieve the dynamic type size.
+
+2014-04-14 Sanimir Agovic <sanimir.agovic@intel.com>
+
* eval.c (evaluate_subexp_for_sizeof) <OP_VAR_VALUE>: If the type
passed to sizeof is dynamic evaluate the argument to compute the length.
diff --git a/gdb/eval.c b/gdb/eval.c
index 85523cd..22392eb 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -3026,7 +3026,9 @@ evaluate_subexp_for_sizeof (struct expression *exp, int *pos)
&& TYPE_CODE (type) != TYPE_CODE_ARRAY)
error (_("Attempt to take contents of a non-pointer value."));
type = TYPE_TARGET_TYPE (type);
- break;
+ if (is_dynamic_type (type))
+ type = value_type (value_ind (val));
+ return value_from_longest (size_type, (LONGEST) TYPE_LENGTH (type));
case UNOP_MEMVAL:
(*pos) += 3;
--
1.8.3.2
next prev parent reply other threads:[~2014-04-14 17:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 12:42 [PATCH v6 00/15] Please have a final look Sanimir Agovic
2014-04-10 12:42 ` [PATCH v6 01/15] refactoring: rename create_range_type to create_static_range_type Sanimir Agovic
2014-04-10 12:43 ` [PATCH v6 02/15] vla: introduce new bound type abstraction adapt uses Sanimir Agovic
2014-04-10 12:44 ` [PATCH v6 03/15] type: add c99 variable length array support Sanimir Agovic
2014-04-10 14:21 ` Joel Brobecker
2014-04-10 12:44 ` [PATCH v6 04/15] vla: enable sizeof operator to work with variable length arrays Sanimir Agovic
2014-04-10 12:45 ` [PATCH v6 05/15] vla: enable sizeof operator for indirection Sanimir Agovic
2014-04-10 12:46 ` [PATCH v6 06/15] vla: update type from newly created value Sanimir Agovic
2014-04-10 12:47 ` [PATCH v6 07/15] vla: print "variable length" for unresolved dynamic bounds Sanimir Agovic
2014-04-10 12:48 ` [PATCH v6 08/15] vla: support for DW_AT_count Sanimir Agovic
2014-04-10 12:48 ` [PATCH v6 09/15] vla: resolve dynamic bounds if value contents is a constant byte-sequence Sanimir Agovic
2014-04-10 14:22 ` Joel Brobecker
2014-04-10 12:49 ` [PATCH v6 10/15] vla: evaluate operand of sizeof if its type is a vla Sanimir Agovic
2014-04-10 14:31 ` Joel Brobecker
2014-04-10 12:49 ` [PATCH v6 11/15] test: cover subranges with present DW_AT_count attribute Sanimir Agovic
2014-04-10 12:50 ` [PATCH v6 12/15] test: multi-dimensional c99 vla Sanimir Agovic
2014-04-10 12:51 ` [PATCH v6 13/15] test: evaluate pointers to C99 vla correctly Sanimir Agovic
2014-04-10 12:52 ` [PATCH v6 14/15] test: basic c99 vla tests for C primitives Sanimir Agovic
2014-04-10 12:53 ` [PATCH v6 15/15] test: add mi vla test Sanimir Agovic
2014-04-10 14:39 ` [PATCH v6 00/15] Please have a final look Joel Brobecker
2014-04-10 14:46 ` Joel Brobecker
2014-04-22 15:33 ` Agovic, Sanimir
2014-04-22 16:58 ` Eli Zaretskii
2014-04-11 12:50 ` Agovic, Sanimir
2014-04-11 20:03 ` Keith Seitz
2014-04-11 20:27 ` Joel Brobecker
2014-04-11 20:33 ` Keith Seitz
2014-04-11 21:13 ` Joel Brobecker
2014-04-11 21:19 ` Keith Seitz
2014-04-11 22:33 ` Joel Brobecker
2014-04-14 8:34 ` Agovic, Sanimir
2014-04-14 17:13 ` [vla v7 pushed] " Joel Brobecker
2014-04-14 17:13 ` [PATCH 08/12] vla: evaluate operand of sizeof if its type is a vla Joel Brobecker
2014-04-14 17:13 ` [PATCH 01/12] type: add c99 variable length array support Joel Brobecker
2014-04-18 19:06 ` Joel Brobecker
2014-04-14 17:13 ` [PATCH 02/12] vla: enable sizeof operator to work with variable length arrays Joel Brobecker
2014-04-14 17:13 ` [PATCH 04/12] vla: update type from newly created value Joel Brobecker
2014-04-14 17:13 ` [PATCH 07/12] vla: resolve dynamic bounds if value contents is a constant byte-sequence Joel Brobecker
2014-04-14 17:13 ` [PATCH 06/12] vla: support for DW_AT_count Joel Brobecker
2014-04-14 17:13 ` Joel Brobecker [this message]
2014-04-14 17:13 ` [PATCH 05/12] vla: print "variable length" for unresolved dynamic bounds Joel Brobecker
2014-04-14 17:14 ` [PATCH 12/12] test: add mi vla test Joel Brobecker
2014-04-14 17:14 ` [PATCH 10/12] test: evaluate pointers to C99 vla correctly Joel Brobecker
2014-04-14 17:14 ` [PATCH 11/12] test: basic c99 vla tests for C primitives Joel Brobecker
2014-04-14 17:14 ` [PATCH 09/12] test: cover subranges with present DW_AT_count attribute Joel Brobecker
2014-04-14 17:36 ` [vla v7 pushed] Re: [PATCH v6 00/15] Please have a final look Agovic, Sanimir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397495596-25364-4-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=sanimir.agovic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox