Re: [PATCH v6 00/15] Please have a final look

[Joel Brobecker <brobecker@adacore.com>]

> >How come this didn't show up in Sanimir's testing?
> 
> I don't know. Maybe my sandbox is messed up? It *is* Friday afterall! :-)

It must be Friday for both of us, then - as I was able to reproduce
at least some of the failures. I am testing each patch in sequence
and so far, two of them cause additional failures:

commit 37c1ab67a35025d37d42c449deab5f254f9f59da
Subject: type: add c99 variable length array support

  This one only causes new failire in gdb.ada

commit bcd629a44fff61527430f353cf77e20fe3afc395
Subject: vla: update type from newly created value

  This one causes new failures in gdb.base, gdb.cp, etc.

> >I'm doing a quick round of testing with what's left of my day today,
> >but we might have to revert the patch series to allow us more time
> >to investigate.
> 
> Would you like me to hold off on committing my c++/16675 patchset?
> That touches eval.c:evaluate_subexp_for_sizeof. It's not a huge deal
> IMO. A Most of the "conflict" is simply that I chose to refactor
> this function a little. [i.e., remove all the "return
> value_from_longest" and collect them at the end of the function]

You should do whatever is convenient for you, and I will work around it.
No reason to inconvenience you further! So, if you are ready, just
go ahead and push. I will review the errors and decide from there
whether we can wait until early next week to fix them or else if
we should revert now.

Thanks!
-- 
Joel