History saving should stay disabled for test cases

History saving should stay disabled for test cases

[mbilal]

I saw some test cases in gdb.base/default.exp and gdb.base/setshow.exp 
are enabling the history saving.
Hence .gdb_history file is modified with history information even 
though, by default, we have History saving disabled.
So we should modify GDB test cases so that history saving should stay 
off for all test cases.
Following is a proposed patch:


diff --git a/gdb/testsuite/gdb.base/default.exp 
b/gdb/testsuite/gdb.base/default.exp
index 6920090..4a1e91f 100644
--- a/gdb/testsuite/gdb.base/default.exp
+++ b/gdb/testsuite/gdb.base/default.exp
@@ -725,6 +725,8 @@ gdb_test_multiple "show" "show" {
         }
      }
  }
+#history saving should stay disabled
+gdb_test_no_output "set history save off" "set history save off"
  #test stepi "si" abbreviation
  gdb_test  "si" "The program is not being run." "stepi \"si\" abbreviation"
  #test stepi
diff --git a/gdb/testsuite/gdb.base/setshow.exp 
b/gdb/testsuite/gdb.base/setshow.exp
index c78d2df..992ade4 100644
--- a/gdb/testsuite/gdb.base/setshow.exp
+++ b/gdb/testsuite/gdb.base/setshow.exp
@@ -178,6 +178,8 @@ gdb_test "show history filename" "The filename in 
which to record the command hi
  gdb_test_no_output "set history save on" "set history save on"
  #test show history save on
  gdb_test "show history save" "Saving of the history record on exit is 
on..*"  "show history save (on)"
+#history saving should stay disabled
+gdb_test_no_output "set history save off" "set history save off"
  #test set history size 100
  gdb_test_no_output "set history size 100" "set history size 100"
  #test show history size 100
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3d928bb..c7e0741 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2013-05-09  Muhammad Bilal  <mbilal@codesourcery.com>
+
+       * gdb.base/default.exp: Disabled history saving.
+       * gdb.base/setshaow.exp: likewise.
+
  2013-05-06  Sandra Loosemore  <sandra@codesourcery.com>

         * gdb.xml/tdesc-regs.exp: Add case for nios2.



OK?

Thanks,
-Bilal

Re: History saving should stay disabled for test cases

[Pedro Alves]

Thanks, that looks much better!

> +2013-05-09  Muhammad Bilal  <mbilal@codesourcery.com>
> +
> +       * gdb.base/default.exp: Disabled history saving.

No past tense:

s/Disabled/Disable/

> +       * gdb.base/setshaow.exp: likewise.

typo, setshow.exp.

Note that the standard is to include the ChangeLog entry
in plain text in the body of the email instead of including
it in the patch.

Please go ahead and commit.  It'd be great if you put the
subject+rationale in the commit log, as well as the (fixed)
ChangeLog entry, so that it's just a cvs log / git log away.

Thanks,
-- 
Pedro Alves

Re: History saving should stay disabled for test cases

[mbilal]

Checked in http://sourceware.org/ml/gdb-cvs/2013-05/msg00100.html


Thanks,
-Bilal