Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: mbilal <mbilal@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: History saving should stay disabled for test cases
Date: Thu, 09 May 2013 16:36:00 -0000	[thread overview]
Message-ID: <518BD08D.8020500@redhat.com> (raw)
In-Reply-To: <518BCAFF.2010004@codesourcery.com>

Thanks, that looks much better!

> +2013-05-09  Muhammad Bilal  <mbilal@codesourcery.com>
> +
> +       * gdb.base/default.exp: Disabled history saving.

No past tense:

s/Disabled/Disable/

> +       * gdb.base/setshaow.exp: likewise.

typo, setshow.exp.

Note that the standard is to include the ChangeLog entry
in plain text in the body of the email instead of including
it in the patch.

Please go ahead and commit.  It'd be great if you put the
subject+rationale in the commit log, as well as the (fixed)
ChangeLog entry, so that it's just a cvs log / git log away.

Thanks,
-- 
Pedro Alves


  reply	other threads:[~2013-05-09 16:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09 16:13 mbilal
2013-05-09 16:36 ` Pedro Alves [this message]
2013-05-13  8:52 ` mbilal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518BD08D.8020500@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mbilal@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox