Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: mbilal <mbilal@codesourcery.com>
To: <gdb-patches@sourceware.org>, <palves@redhat.com>
Subject: History saving should stay disabled for test cases
Date: Thu, 09 May 2013 16:13:00 -0000	[thread overview]
Message-ID: <518BCAFF.2010004@codesourcery.com> (raw)

I saw some test cases in gdb.base/default.exp and gdb.base/setshow.exp 
are enabling the history saving.
Hence .gdb_history file is modified with history information even 
though, by default, we have History saving disabled.
So we should modify GDB test cases so that history saving should stay 
off for all test cases.
Following is a proposed patch:


diff --git a/gdb/testsuite/gdb.base/default.exp 
b/gdb/testsuite/gdb.base/default.exp
index 6920090..4a1e91f 100644
--- a/gdb/testsuite/gdb.base/default.exp
+++ b/gdb/testsuite/gdb.base/default.exp
@@ -725,6 +725,8 @@ gdb_test_multiple "show" "show" {
         }
      }
  }
+#history saving should stay disabled
+gdb_test_no_output "set history save off" "set history save off"
  #test stepi "si" abbreviation
  gdb_test  "si" "The program is not being run." "stepi \"si\" abbreviation"
  #test stepi
diff --git a/gdb/testsuite/gdb.base/setshow.exp 
b/gdb/testsuite/gdb.base/setshow.exp
index c78d2df..992ade4 100644
--- a/gdb/testsuite/gdb.base/setshow.exp
+++ b/gdb/testsuite/gdb.base/setshow.exp
@@ -178,6 +178,8 @@ gdb_test "show history filename" "The filename in 
which to record the command hi
  gdb_test_no_output "set history save on" "set history save on"
  #test show history save on
  gdb_test "show history save" "Saving of the history record on exit is 
on..*"  "show history save (on)"
+#history saving should stay disabled
+gdb_test_no_output "set history save off" "set history save off"
  #test set history size 100
  gdb_test_no_output "set history size 100" "set history size 100"
  #test show history size 100
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3d928bb..c7e0741 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2013-05-09  Muhammad Bilal  <mbilal@codesourcery.com>
+
+       * gdb.base/default.exp: Disabled history saving.
+       * gdb.base/setshaow.exp: likewise.
+
  2013-05-06  Sandra Loosemore  <sandra@codesourcery.com>

         * gdb.xml/tdesc-regs.exp: Add case for nios2.



OK?

Thanks,
-Bilal


             reply	other threads:[~2013-05-09 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09 16:13 mbilal [this message]
2013-05-09 16:36 ` Pedro Alves
2013-05-13  8:52 ` mbilal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518BCAFF.2010004@codesourcery.com \
    --to=mbilal@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox