From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19890 invoked by alias); 9 May 2013 16:13:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19840 invoked by uid 89); 9 May 2013 16:12:55 -0000 X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 09 May 2013 16:12:54 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UaTSe-0001z9-Ex from Muhammad_Bilal@mentor.com ; Thu, 09 May 2013 09:12:52 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 9 May 2013 09:12:52 -0700 Received: from [137.202.157.37] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Thu, 9 May 2013 17:12:49 +0100 Message-ID: <518BCAFF.2010004@codesourcery.com> Date: Thu, 09 May 2013 16:13:00 -0000 From: mbilal User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: , Subject: History saving should stay disabled for test cases Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00312.txt.bz2 I saw some test cases in gdb.base/default.exp and gdb.base/setshow.exp are enabling the history saving. Hence .gdb_history file is modified with history information even though, by default, we have History saving disabled. So we should modify GDB test cases so that history saving should stay off for all test cases. Following is a proposed patch: diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp index 6920090..4a1e91f 100644 --- a/gdb/testsuite/gdb.base/default.exp +++ b/gdb/testsuite/gdb.base/default.exp @@ -725,6 +725,8 @@ gdb_test_multiple "show" "show" { } } } +#history saving should stay disabled +gdb_test_no_output "set history save off" "set history save off" #test stepi "si" abbreviation gdb_test "si" "The program is not being run." "stepi \"si\" abbreviation" #test stepi diff --git a/gdb/testsuite/gdb.base/setshow.exp b/gdb/testsuite/gdb.base/setshow.exp index c78d2df..992ade4 100644 --- a/gdb/testsuite/gdb.base/setshow.exp +++ b/gdb/testsuite/gdb.base/setshow.exp @@ -178,6 +178,8 @@ gdb_test "show history filename" "The filename in which to record the command hi gdb_test_no_output "set history save on" "set history save on" #test show history save on gdb_test "show history save" "Saving of the history record on exit is on..*" "show history save (on)" +#history saving should stay disabled +gdb_test_no_output "set history save off" "set history save off" #test set history size 100 gdb_test_no_output "set history size 100" "set history size 100" #test show history size 100 diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 3d928bb..c7e0741 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-05-09 Muhammad Bilal + + * gdb.base/default.exp: Disabled history saving. + * gdb.base/setshaow.exp: likewise. + 2013-05-06 Sandra Loosemore * gdb.xml/tdesc-regs.exp: Add case for nios2. OK? Thanks, -Bilal