From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3221 invoked by alias); 9 May 2013 16:36:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3195 invoked by uid 89); 9 May 2013 16:36:34 -0000 X-Spam-SWARE-Status: No, score=-8.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 09 May 2013 16:36:34 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r49GaV4r011811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 May 2013 12:36:31 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r49GaTlM019223; Thu, 9 May 2013 12:36:31 -0400 Message-ID: <518BD08D.8020500@redhat.com> Date: Thu, 09 May 2013 16:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: mbilal CC: gdb-patches@sourceware.org Subject: Re: History saving should stay disabled for test cases References: <518BCAFF.2010004@codesourcery.com> In-Reply-To: <518BCAFF.2010004@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00313.txt.bz2 Thanks, that looks much better! > +2013-05-09 Muhammad Bilal > + > + * gdb.base/default.exp: Disabled history saving. No past tense: s/Disabled/Disable/ > + * gdb.base/setshaow.exp: likewise. typo, setshow.exp. Note that the standard is to include the ChangeLog entry in plain text in the body of the email instead of including it in the patch. Please go ahead and commit. It'd be great if you put the subject+rationale in the commit log, as well as the (fixed) ChangeLog entry, so that it's just a cvs log / git log away. Thanks, -- Pedro Alves