From: mbilal <mbilal@codesourcery.com>
To: <palves@redhat.com>, <gdb-patches@sourceware.org>,
<jan.kratochvil@redhat.com>
Subject: Re: [PATCH 2/7] PR gdb/15224 fix for Unify interactivity tests to use input_from_terminal_p
Date: Tue, 07 May 2013 07:26:00 -0000 [thread overview]
Message-ID: <5188AC99.6060504@codesourcery.com> (raw)
In-Reply-To: <5188AC27.1050407@codesourcery.com>
Here is a updated patch for fix for Unify interactivity tests to use
input_from_terminal_p:
On Monday, May 06, 2013 4:26 PM Pedro Alves wrote:
>Please do this in the command's set handler rather than
>hacking in the the set/show machinery.
Thanks Pedro for correct guide line
Index: event-top.c
===================================================================
RCS file: /cvs/src/src/gdb/event-top.c,v
retrieving revision 1.94
diff -u -p -r1.94 event-top.c
--- event-top.c 21 Mar 2013 17:37:29 -0000 1.94
+++ event-top.c 7 May 2013 07:03:33 -0000
@@ -604,7 +604,8 @@ command_line_handler (char *rl)
/* Add line to history if appropriate. */
if (instream == stdin
- && ISATTY (stdin) && *linebuffer)
+ && ISATTY (stdin) && *linebuffer
+ && input_from_terminal_p())
add_history (linebuffer);
/* Note: lines consisting solely of comments are added to the command
And please help me to review other patchesas well.
Thanks,
-Bilal
next prev parent reply other threads:[~2013-05-07 7:26 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 9:39 [PATCH 0/7] PR gdb/15224 should "set history save on" by default mbilal
2013-05-06 9:40 ` [PATCH 1/7] " mbilal
2013-05-06 9:42 ` [PATCH 2/7] " mbilal
2013-05-06 9:43 ` [PATCH 3/7] " mbilal
[not found] ` <51877BC6.6080007@codesourcery.com>
2013-05-06 9:47 ` [PATCH 4/7] " mbilal
2013-05-07 9:40 ` Abid, Hafiz
2013-05-08 17:14 ` Pedro Alves
2013-05-06 9:48 ` [PATCH 5/7] " mbilal
2013-05-08 8:24 ` mbilal
2013-05-15 11:08 ` [PATCH 5/7] PR gdb/15224 , Change the default set history filename to ~/.gdb_history mbilal
2013-05-15 11:31 ` Eli Zaretskii
2013-05-15 12:07 ` mbilal
2013-05-15 13:27 ` Eli Zaretskii
2013-05-22 17:24 ` Pedro Alves
2013-05-22 17:49 ` Eli Zaretskii
2013-05-22 18:08 ` Pedro Alves
2013-05-22 19:18 ` Eli Zaretskii
2013-05-22 19:39 ` Pedro Alves
2013-08-01 12:43 ` Muhammad Bilal
2013-08-01 15:41 ` Tom Tromey
2013-08-01 22:17 ` Doug Evans
2013-05-22 12:02 ` mbilal
2013-05-08 17:05 ` [PATCH 5/7] PR gdb/15224 should "set history save on" by default Pedro Alves
2013-05-06 9:49 ` [PATCH 6/7] " mbilal
2013-05-06 9:51 ` [PATCH 7/7] " mbilal
2013-05-07 10:17 ` Abid, Hafiz
2013-05-08 17:08 ` Pedro Alves
2013-05-08 8:25 ` mbilal
2013-05-08 16:51 ` Eli Zaretskii
2013-05-08 17:18 ` Pedro Alves
2013-05-08 8:23 ` [PATCH 4/7] " mbilal
2013-05-09 11:12 ` mbilal
2013-05-09 12:05 ` Pedro Alves
[not found] ` <51936853.7050106@codesourcery.com>
[not found] ` <51936944.80108@codesourcery.com>
2013-05-15 10:56 ` [PATCH 4/7] Disable history saving for testsuit mbilal
2013-05-22 12:02 ` mbilal
2013-05-22 17:27 ` Pedro Alves
2013-05-08 8:23 ` [PATCH 3/7] PR gdb/15224 should "set history save on" by default mbilal
2013-05-08 16:24 ` Pedro Alves
2013-05-06 11:26 ` [PATCH 1/7] " Pedro Alves
[not found] ` <5188AA15.5010904@codesourcery.com>
2013-05-07 7:19 ` [PATCH 1/7] PR gdb/15224 "set history filename" to by immediately converted to absolute path mbilal
2013-05-07 8:39 ` Pedro Alves
[not found] ` <5188AC27.1050407@codesourcery.com>
2013-05-07 7:26 ` mbilal [this message]
2013-05-08 8:22 ` [PATCH 2/7] PR gdb/15224 fix for Unify interactivity tests to use input_from_terminal_p mbilal
2013-05-08 16:21 ` Pedro Alves
2013-05-09 11:08 ` mbilal
2013-05-09 11:32 ` Pedro Alves
2013-05-07 12:44 ` [PATCH 1/7] PR gdb/15224 "set history filename" to by immediately converted to absolute path mbilal
2013-05-08 8:22 ` mbilal
[not found] ` <519366E2.90105@codesourcery.com>
2013-05-15 10:46 ` mbilal
2013-05-22 17:51 ` Pedro Alves
2013-05-22 12:04 ` mbilal
2013-05-08 15:46 ` Pedro Alves
2013-05-08 17:25 ` Pedro Alves
2013-05-07 10:01 ` [PATCH 0/7] PR gdb/15224 should "set history save on" by default Abid, Hafiz
2013-08-06 16:35 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5188AC99.6060504@codesourcery.com \
--to=mbilal@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox