From: mbilal <mbilal@codesourcery.com>
To: <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>, <jan.kratochvil@redhat.com>
Subject: Re: [PATCH 1/7] PR gdb/15224 "set history filename" to by immediately converted to absolute path
Date: Tue, 07 May 2013 12:44:00 -0000 [thread overview]
Message-ID: <5188F70A.1030908@codesourcery.com> (raw)
In-Reply-To: <5188AA15.5010904@codesourcery.com>
please find updated patch .
I made new 'set_history_filename' function to solve this problem
and thanks Pedro for review this patch.
diff --git a/gdb/top.c b/gdb/top.c
index 480b67e..20aecc9 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -48,6 +48,7 @@
#include "interps.h"
#include "observer.h"
#include "maint.h"
+#include "filenames.h"
/* readline include files. */
#include "readline/readline.h"
@@ -1607,6 +1608,14 @@ set_verbose (char *args, int from_tty, struct
cmd_list_element *c)
}
}
+static void
+set_history_filename (char *args, int from_tty, struct cmd_list_element *c)
+{
+ if (!IS_ABSOLUTE_PATH (*(char **) c->var))
+ *(char **) c->var = concat (current_directory, "/", *(char **) c->var,
+ (char *)NULL);
+}
+
/* Init the history buffer. Note that we are called after the init
file(s)
have been read so that the user can change the history file via his
.gdbinit file (for instance). The GDBHISTFILE environment variable
@@ -1777,7 +1786,7 @@ variable \"HISTSIZE\", or to 256 if this variable
is not set."),
Set the filename in which to record the command history"), _("\
Show the filename in which to record the command history"), _("\
(the list of previous commands of which a record is kept)."),
- NULL,
+ set_history_filename,
show_history_filename,
&sethistlist, &showhistlist);
Thanks,
-Bilal
next prev parent reply other threads:[~2013-05-07 12:44 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 9:39 [PATCH 0/7] PR gdb/15224 should "set history save on" by default mbilal
2013-05-06 9:40 ` [PATCH 1/7] " mbilal
2013-05-06 9:42 ` [PATCH 2/7] " mbilal
2013-05-06 9:43 ` [PATCH 3/7] " mbilal
[not found] ` <51877BC6.6080007@codesourcery.com>
2013-05-06 9:47 ` [PATCH 4/7] " mbilal
2013-05-07 9:40 ` Abid, Hafiz
2013-05-08 17:14 ` Pedro Alves
2013-05-06 9:48 ` [PATCH 5/7] " mbilal
2013-05-08 8:24 ` mbilal
2013-05-15 11:08 ` [PATCH 5/7] PR gdb/15224 , Change the default set history filename to ~/.gdb_history mbilal
2013-05-15 11:31 ` Eli Zaretskii
2013-05-15 12:07 ` mbilal
2013-05-15 13:27 ` Eli Zaretskii
2013-05-22 17:24 ` Pedro Alves
2013-05-22 17:49 ` Eli Zaretskii
2013-05-22 18:08 ` Pedro Alves
2013-05-22 19:18 ` Eli Zaretskii
2013-05-22 19:39 ` Pedro Alves
2013-08-01 12:43 ` Muhammad Bilal
2013-08-01 15:41 ` Tom Tromey
2013-08-01 22:17 ` Doug Evans
2013-05-22 12:02 ` mbilal
2013-05-08 17:05 ` [PATCH 5/7] PR gdb/15224 should "set history save on" by default Pedro Alves
2013-05-06 9:49 ` [PATCH 6/7] " mbilal
2013-05-06 9:51 ` [PATCH 7/7] " mbilal
2013-05-07 10:17 ` Abid, Hafiz
2013-05-08 17:08 ` Pedro Alves
2013-05-08 8:25 ` mbilal
2013-05-08 16:51 ` Eli Zaretskii
2013-05-08 17:18 ` Pedro Alves
2013-05-08 8:23 ` [PATCH 4/7] " mbilal
2013-05-09 11:12 ` mbilal
2013-05-09 12:05 ` Pedro Alves
[not found] ` <51936853.7050106@codesourcery.com>
[not found] ` <51936944.80108@codesourcery.com>
2013-05-15 10:56 ` [PATCH 4/7] Disable history saving for testsuit mbilal
2013-05-22 12:02 ` mbilal
2013-05-22 17:27 ` Pedro Alves
2013-05-08 8:23 ` [PATCH 3/7] PR gdb/15224 should "set history save on" by default mbilal
2013-05-08 16:24 ` Pedro Alves
2013-05-06 11:26 ` [PATCH 1/7] " Pedro Alves
[not found] ` <5188AA15.5010904@codesourcery.com>
2013-05-07 7:19 ` [PATCH 1/7] PR gdb/15224 "set history filename" to by immediately converted to absolute path mbilal
2013-05-07 8:39 ` Pedro Alves
[not found] ` <5188AC27.1050407@codesourcery.com>
2013-05-07 7:26 ` [PATCH 2/7] PR gdb/15224 fix for Unify interactivity tests to use input_from_terminal_p mbilal
2013-05-08 8:22 ` mbilal
2013-05-08 16:21 ` Pedro Alves
2013-05-09 11:08 ` mbilal
2013-05-09 11:32 ` Pedro Alves
2013-05-07 12:44 ` mbilal [this message]
2013-05-08 8:22 ` [PATCH 1/7] PR gdb/15224 "set history filename" to by immediately converted to absolute path mbilal
[not found] ` <519366E2.90105@codesourcery.com>
2013-05-15 10:46 ` mbilal
2013-05-22 17:51 ` Pedro Alves
2013-05-22 12:04 ` mbilal
2013-05-08 15:46 ` Pedro Alves
2013-05-08 17:25 ` Pedro Alves
2013-05-07 10:01 ` [PATCH 0/7] PR gdb/15224 should "set history save on" by default Abid, Hafiz
2013-08-06 16:35 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5188F70A.1030908@codesourcery.com \
--to=mbilal@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox