From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mbilal@codesourcery.com, gdb-patches@sourceware.org,
jan.kratochvil@redhat.com
Subject: Re: [PATCH 5/7] PR gdb/15224 , Change the default set history filename to ~/.gdb_history.
Date: Wed, 22 May 2013 18:08:00 -0000 [thread overview]
Message-ID: <519D099F.7090101@redhat.com> (raw)
In-Reply-To: <83bo82ucpv.fsf@gnu.org>
On 05/22/2013 06:49 PM, Eli Zaretskii wrote:
>> Date: Wed, 22 May 2013 18:24:13 +0100
>> From: Pedro Alves <palves@redhat.com>
>> CC: mbilal <mbilal@codesourcery.com>, gdb-patches@sourceware.org,
>> jan.kratochvil@redhat.com
>>
>> At startup time, if "set history filename" hasn't been
>> used (tracked with a new global flag), then check whether there's
>> a $cwd/.gdb_history file, and if so, output a warning stating that
>> it's no longer read by default. The warning could also
>> suggest adding "set history filename .gdb_history" to .gdbinit
>> to get back the old behavior.
>
> That's even more annoying, IMO.
>
> I think gratuitous backward incompatibility is evil, especially in
> programs, like GDB, where there are no good facilities for
> version-specific scripting. We are breaking scripts out there for no
> good reason, and we aren't giving the users of those scripts _any_
> means to get their previous behavior cleanly.
I understand the sentiment, but I'd rather not generalize, and look
at it on a case by case basis. Scripts do have a means get the
previous behavior. Simply adding this to .gdbinit:
"set history filename .gdb_history"
get you the old behavior back. And works the same with the
older GDBs too. Note the user must already have added
"set history save on"
to .gdbinit in previous releases to have history saving.
He'll just need to add one more line next to that.
If you're talking about getting the previous behavior of
not having history enabled, then the user can just add
"set history save off"
to .gdbinit.
> But I know I'm somehow in the minority here. It's probably the age or
> something.
:-)
The reasoning for changing the default is that we (Pedro/Jan/Muhammad)
believe enabling history by default is a better default that having it
disabled by default, as currently. Couple the fact that ".gdb_history"
is a dot/hidden file, with enabling history saving by default, and users
could end up with their filesystem littered with random hidden .gdb_history
files. I think GDB shouldn't do that by default. So in order to enable
history saving by default, we believe we should default to ~/.gdb_history
instead first. bash also defaults to saving history under $HOME, and I'd
think most other interactive programs/shell do so too. So it feels like
GDB is the odd one out here.
--
Pedro Alves
next prev parent reply other threads:[~2013-05-22 18:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 9:39 [PATCH 0/7] PR gdb/15224 should "set history save on" by default mbilal
2013-05-06 9:40 ` [PATCH 1/7] " mbilal
2013-05-06 9:42 ` [PATCH 2/7] " mbilal
2013-05-06 9:43 ` [PATCH 3/7] " mbilal
[not found] ` <51877BC6.6080007@codesourcery.com>
2013-05-06 9:47 ` [PATCH 4/7] " mbilal
2013-05-07 9:40 ` Abid, Hafiz
2013-05-08 17:14 ` Pedro Alves
2013-05-06 9:48 ` [PATCH 5/7] " mbilal
2013-05-08 8:24 ` mbilal
2013-05-15 11:08 ` [PATCH 5/7] PR gdb/15224 , Change the default set history filename to ~/.gdb_history mbilal
2013-05-15 11:31 ` Eli Zaretskii
2013-05-15 12:07 ` mbilal
2013-05-15 13:27 ` Eli Zaretskii
2013-05-22 17:24 ` Pedro Alves
2013-05-22 17:49 ` Eli Zaretskii
2013-05-22 18:08 ` Pedro Alves [this message]
2013-05-22 19:18 ` Eli Zaretskii
2013-05-22 19:39 ` Pedro Alves
2013-08-01 12:43 ` Muhammad Bilal
2013-08-01 15:41 ` Tom Tromey
2013-08-01 22:17 ` Doug Evans
2013-05-22 12:02 ` mbilal
2013-05-08 17:05 ` [PATCH 5/7] PR gdb/15224 should "set history save on" by default Pedro Alves
2013-05-06 9:49 ` [PATCH 6/7] " mbilal
2013-05-06 9:51 ` [PATCH 7/7] " mbilal
2013-05-07 10:17 ` Abid, Hafiz
2013-05-08 17:08 ` Pedro Alves
2013-05-08 8:25 ` mbilal
2013-05-08 16:51 ` Eli Zaretskii
2013-05-08 17:18 ` Pedro Alves
2013-05-08 8:23 ` [PATCH 4/7] " mbilal
2013-05-09 11:12 ` mbilal
2013-05-09 12:05 ` Pedro Alves
[not found] ` <51936853.7050106@codesourcery.com>
[not found] ` <51936944.80108@codesourcery.com>
2013-05-15 10:56 ` [PATCH 4/7] Disable history saving for testsuit mbilal
2013-05-22 12:02 ` mbilal
2013-05-22 17:27 ` Pedro Alves
2013-05-08 8:23 ` [PATCH 3/7] PR gdb/15224 should "set history save on" by default mbilal
2013-05-08 16:24 ` Pedro Alves
2013-05-06 11:26 ` [PATCH 1/7] " Pedro Alves
[not found] ` <5188AA15.5010904@codesourcery.com>
2013-05-07 7:19 ` [PATCH 1/7] PR gdb/15224 "set history filename" to by immediately converted to absolute path mbilal
2013-05-07 8:39 ` Pedro Alves
[not found] ` <5188AC27.1050407@codesourcery.com>
2013-05-07 7:26 ` [PATCH 2/7] PR gdb/15224 fix for Unify interactivity tests to use input_from_terminal_p mbilal
2013-05-08 8:22 ` mbilal
2013-05-08 16:21 ` Pedro Alves
2013-05-09 11:08 ` mbilal
2013-05-09 11:32 ` Pedro Alves
2013-05-07 12:44 ` [PATCH 1/7] PR gdb/15224 "set history filename" to by immediately converted to absolute path mbilal
2013-05-08 8:22 ` mbilal
[not found] ` <519366E2.90105@codesourcery.com>
2013-05-15 10:46 ` mbilal
2013-05-22 17:51 ` Pedro Alves
2013-05-22 12:04 ` mbilal
2013-05-08 15:46 ` Pedro Alves
2013-05-08 17:25 ` Pedro Alves
2013-05-07 10:01 ` [PATCH 0/7] PR gdb/15224 should "set history save on" by default Abid, Hafiz
2013-08-06 16:35 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519D099F.7090101@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mbilal@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox