Re: [PATCH 4/7] PR gdb/15224 should "set history save on" by default

[mbilal <mbilal@codesourcery.com>]

On Wednesday, May 08, 2013 10:14 PM pedro Alves wrote:

 >> -    set INTERNAL_GDBFLAGS "-nw -nx -data-directory 
$BUILD_DATA_DIRECTORY"
 >> +    set INTERNAL_GDBFLAGS "-nw -nx  -ex set\\ history\\ save\\ off 
-data-directory $BUILD_DATA_DIRECTORY"

 >spurious space?               ------^^

Fixed.


 >> +#We are always disable history saving on testsuite
 >>  #test set history save
 >> -gdb_test_no_output "set history save" "set history save"
 >> +#gdb_test_no_output "set history save" "set history save"
 >>  #test set history size

 >I don't understand this.  Why disable the test?

We are disabling the history saving on all testsuit, if we run the above
testsuit then history saving becomes enable that will also writes the 
history
command on .gdb_history file. That's why I disabled this test case.



On Tuesday, May 07, 2013 2:40 PM Hafiz Abid wrote:

 >> +#We are always disable history saving on testsuite
 >s/are always disable/always disable/

fixed .



please find updated patch.

Index: testsuite/lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.230
diff -u -p -r1.230 gdb.exp
--- testsuite/lib/gdb.exp    15 Apr 2013 20:37:37 -0000    1.230
+++ testsuite/lib/gdb.exp    9 May 2013 10:38:18 -0000
@@ -58,7 +58,7 @@ set BUILD_DATA_DIRECTORY "[pwd]/../data-
  # INTERNAL_GDBFLAGS contains flags that the testsuite requires.
  global INTERNAL_GDBFLAGS
  if ![info exists INTERNAL_GDBFLAGS] {
-    set INTERNAL_GDBFLAGS "-nw -nx -data-directory $BUILD_DATA_DIRECTORY"
+    set INTERNAL_GDBFLAGS "-nw -nx -ex set\\ history\\ save\\ off 
-data-directory $BUILD_DATA_DIRECTORY"
  }
Index: gdb.base/default.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
retrieving revision 1.64
diff -u -p -r1.64 default.exp
--- gdb.base/default.exp    15 Apr 2013 18:09:02 -0000    1.64
+++ gdb.base/default.exp    6 May 2013 07:02:53 -0000
@@ -521,8 +521,9 @@ gdb_test "set height" "Argument required
  gdb_test_no_output "set history expansion" "set history expansion"
  #test set history filename
  gdb_test "set history filename" "Argument required .filename to set it 
to.*" "set history filename"
+#We always disable history saving on testsuite
  #test set history save
-gdb_test_no_output "set history save" "set history save"
+#gdb_test_no_output "set history save" "set history save"
  #test set history size
  gdb_test "set history size" "Argument required .integer to set it 
to.*" "set history size"
  #test set history
@@ -644,7 +645,7 @@ gdb_test "show history expansion" "Histo
  #test show history filename
  gdb_test "show history filename" "The filename in which to record the 
command history is.*.gdb_history.*" "show history filename"
  #test show history save
-gdb_test "show history save" "Saving of the history record on exit is 
on." "show history save"
+gdb_test "show history save" "Saving of the history record on exit is 
off." "show history save"
  #test show history size
  gdb_test "show history size" "The size of the command history is.*" 
"show history size"
  #test show history
Index: gdb.base/setshow.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/setshow.exp,v
retrieving revision 1.30
diff -u -p -r1.30 setshow.exp
--- gdb.base/setshow.exp    24 Apr 2013 14:29:17 -0000    1.30
+++ gdb.base/setshow.exp    6 May 2013 07:08:29 -0000
@@ -174,10 +174,11 @@ gdb_test_no_output "set history filename
      "set history filename foobar.baz"
  #test show history filename foobar.baz
  gdb_test "show history filename" "The filename in which to record the 
command history is \"foobar.baz\"..*"  "show history filename (foobar.baz)"
+#We always disable history saving on testsuite
  #test set history save on
-gdb_test_no_output "set history save on" "set history save on"
+#gdb_test_no_output "set history save on" "set history save on"
  #test show history save on
-gdb_test "show history save" "Saving of the history record on exit is 
on..*"  "show history save (on)"
+gdb_test "show history save" "Saving of the history record on exit is 
off..*"  "show history save (off)"
  #test set history size 100
  gdb_test_no_output "set history size 100" "set history size 100"
  #test show history size 100
Index: testsuite/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.3640
diff -u -p -r1.3640 ChangeLog
--- testsuite/ChangeLog    30 Apr 2013 12:33:51 -0000    1.3640
+++ testsuite/ChangeLog    9 May 2013 11:04:17 -0000
@@ -1,3 +1,11 @@
+2013-05-06  Muhammad Bilal  <mbilal@codesourcery.com>
+
+    PR gdb/15224
+    * lib/gdb.exp: Disabled history saving on testsuites.
+    * gdb.base/default.exp: Comment 'set history save' test case.
+    Changed out put of 'show history save' test case.
+    * gdb.base/setshow.exp: Likewise.
+
  2013-03-27  Walfred Tedeschi  <walfred.tedeschi@intel.com>

      * gdb.xml/maint_print_struct.exp: New file.


Thanks,
-Bilal