Re: [PATCH 2/7] PR gdb/15224 fix for Unify interactivity tests to use input_from_terminal_p

mbilal
2013-05-07T07:26:25Z

Here is a updated patch for fix for Unify interactivity tests to use
input_from_terminal_p:
On Monday, May 06, 2013 4:26 PM Pedro Alves wrote:

>Please do this in the command's set handler rather than
>hacking in the the set/show machinery.

Thanks Pedro for correct guide line

Index: event-top.c
===================================================================
RCS file: /cvs/src/src/gdb/event-top.c,v
retrieving revision 1.94
diff -u -p -r1.94 event-top.c
--- event-top.c 21 Mar 2013 17:37:29 -0000 1.94
+++ event-top.c 7 May 2013 07:03:33 -0000
@@ -604,7 +604,8 @@ command_line_handler (char *rl)

/* Add line to history if appropriate. */
if (instream == stdin
- && ISATTY (stdin) && *linebuffer)
+ && ISATTY (stdin) && *linebuffer
+ && input_from_terminal_p())
add_history (linebuffer);

/* Note: lines consisting solely of comments are added to the command

And please help me to review other patchesas well.

Thanks,
-Bilal