New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt

New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt

[GDB Administrator]

623a624
> gdb/remote.c:11047: code: OP eol: Do not use &&, or || at the end of a line
gdb/remote.c:11047:  if (remote_protocol_packets[PACKET_QTBuffer_size].support !=

Re: New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt

[Abid, Hafiz]

On 10/03/13 02:06:07, GDB Administrator wrote:
> 623a624
> > gdb/remote.c:11047: code: OP eol: Do not use &&, or || at the end  
> of a line
> gdb/remote.c:11047:  if  
> (remote_protocol_packets[PACKET_QTBuffer_size].support !=
> 

Hi All,
I noticed the above ARI warning. I will apply the following if there  
are no objections. I think it is obvious.

Regards,
Abid

gdb/ChangeLog:

	* remote.c (remote_set_trace_buffer_size): Move != operator
	to the start of next line to fix an ARI warning.


diff --git a/gdb/remote.c b/gdb/remote.c
index 8fc6b85..c4824e9 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -11056,8 +11056,8 @@ remote_get_min_fast_tracepoint_insn_len (void)
  static void
  remote_set_trace_buffer_size (LONGEST val)
  {
-  if (remote_protocol_packets[PACKET_QTBuffer_size].support !=
-      PACKET_DISABLE)
+  if (remote_protocol_packets[PACKET_QTBuffer_size].support
+      != PACKET_DISABLE)
      {
        struct remote_state *rs = get_remote_state ();
        char *buf = rs->buf;

Re: New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt

[Pedro Alves]

On 03/11/2013 12:03 PM, Abid, Hafiz wrote:
> On 10/03/13 02:06:07, GDB Administrator wrote:
>> 623a624
>> > gdb/remote.c:11047: code: OP eol: Do not use &&, or || at the end of a line
>> gdb/remote.c:11047:  if (remote_protocol_packets[PACKET_QTBuffer_size].support !=
>>
> 
> Hi All,
> I noticed the above ARI warning. I will apply the following if there are no objections. I think it is obvious.

Yes, thanks.  Please go ahead.

> 
> Regards,
> Abid
> 
> gdb/ChangeLog:
> 
>     * remote.c (remote_set_trace_buffer_size): Move != operator
>     to the start of next line to fix an ARI warning.
> 
> 
> diff --git a/gdb/remote.c b/gdb/remote.c
> index 8fc6b85..c4824e9 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -11056,8 +11056,8 @@ remote_get_min_fast_tracepoint_insn_len (void)
>  static void
>  remote_set_trace_buffer_size (LONGEST val)
>  {
> -  if (remote_protocol_packets[PACKET_QTBuffer_size].support !=
> -      PACKET_DISABLE)
> +  if (remote_protocol_packets[PACKET_QTBuffer_size].support
> +      != PACKET_DISABLE)
>      {
>        struct remote_state *rs = get_remote_state ();
>        char *buf = rs->buf;


-- 
Pedro Alves

About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt

[Pierre Muller]

  Thanks for the fast fix of this new ARI regression.

  Reading the comment of the rule shows that it is misleading,
because it says that we should not use && or ||,
but inside the script, it also looks == or != operators.

  I looked at the GNU coding standards,
and those in fact talk about any binary operator...
http://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting

Should I:
1) modify the comment to also list != and ==
2) extend the rule to also check for other binary operators?


Pierre Muller 
as ARI maintainer....

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Abid, Hafiz
> Envoyé : lundi 11 mars 2013 13:04
> À : gdb-patches@sourceware.org
> Objet : Re: New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-
> gmt
> 
> On 10/03/13 02:06:07, GDB Administrator wrote:
> > 623a624
> > > gdb/remote.c:11047: code: OP eol: Do not use &&, or || at the end
> > of a line
> > gdb/remote.c:11047:  if
> > (remote_protocol_packets[PACKET_QTBuffer_size].support !=
> >
> 
> Hi All,
> I noticed the above ARI warning. I will apply the following if there
> are no objections. I think it is obvious.
> 
> Regards,
> Abid
> 
> gdb/ChangeLog:
> 
> 	* remote.c (remote_set_trace_buffer_size): Move != operator
> 	to the start of next line to fix an ARI warning.
> 
> 
> diff --git a/gdb/remote.c b/gdb/remote.c
> index 8fc6b85..c4824e9 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -11056,8 +11056,8 @@ remote_get_min_fast_tracepoint_insn_len (void)
>   static void
>   remote_set_trace_buffer_size (LONGEST val)
>   {
> -  if (remote_protocol_packets[PACKET_QTBuffer_size].support !=
> -      PACKET_DISABLE)
> +  if (remote_protocol_packets[PACKET_QTBuffer_size].support
> +      != PACKET_DISABLE)
>       {
>         struct remote_state *rs = get_remote_state ();
>         char *buf = rs->buf;

Re: About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt

[Joel Brobecker]

Hi Pierre,

> Should I:
> 1) modify the comment to also list != and ==

That, or making it more explicit that the list is not exhaustive.

> 2) extend the rule to also check for other binary operators?

I think it would make sense, yes.

Thanks again for taking care of this part of the project...
-- 
Joel

[RFA] ARI: Extend binary operator at EOL checks (was: About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt)

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : lundi 11 mars 2013 18:59
> À : Pierre Muller
> Cc : 'Abid, Hafiz'; gdb-patches@sourceware.org
> Objet : Re: About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-
> 03-10-gmt
> 
> Hi Pierre,
> 
> > Should I:
> > 1) modify the comment to also list != and ==
> 
> That, or making it more explicit that the list is not exhaustive.
> 
> > 2) extend the rule to also check for other binary operators?
> 
> I think it would make sense, yes.

  Here is a propsoal for this,
it extends the tested binray operator list from
&&, ||, != and ==
to
&&, ||, !=, ==,+, -, / and *.

  The * multiplication required a special handling as
it is present at the end of line
in numerous function definitions like
char *
any_char_function (args)

or other type definitions...


I did not (yet) change the document of the ARI
because this generates a long list of false ARI changes,
thus I plan to do it later so that the true new ARI
warnings generated by this change are not shadowed by
this.

Pierre Muller



 
> Thanks again for taking care of this part of the project...
> --
> Joel

ChangeLog entry:

2013-03-13  Pierre Muller  <muller@sourceware.org>

        * contrib/ari/gdb_ari.sh (OP eol rule): Also check
        addition, subtraction, multiplication and division binary operator.

Index: contrib/ari/gdb_ari.sh
===================================================================
RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v
retrieving revision 1.8
diff -u -p -r1.8 gdb_ari.sh
--- contrib/ari/gdb_ari.sh      14 Feb 2013 21:08:35 -0000      1.8
+++ contrib/ari/gdb_ari.sh      13 Mar 2013 14:31:03 -0000
@@ -609,7 +609,11 @@ BEGIN { doc["OP eol"] = "\
 Do not use &&, or || at the end of a line"
     category["OP eol"] = ari_code
 }
-/(\|\||\&\&|==|!=)[[:space:]]*$/ {
+# * operator needs a special treatment as it can be a
+# valid end of line for a pointer type definition
+# Only catch case where an assignment or an opening brace is present
+/(\|\||\&\&|==|!=|[[:space:]][+\-\/])[[:space:]]*$/ \
+|| /(\(|=)[[:space:]].*[[:space:]]\*[[:space:]]*$/ {
     fail("OP eol")
 }


This leads to the following list of new warnings,
all of them look correct to me:

2a3
> gdb/ada-lang.c:2391: code: OP eol: Do not use &&, or || at the end of a
line
gdb/ada-lang.c:2391:        (1 << (srcBitsLeft >= HOST_CHAR_BIT ?
HOST_CHAR_BIT : srcBitsLeft)) -
4a6
> gdb/ada-lang.c:8622: code: OP eol: Do not use &&, or || at the end of a
line
gdb/ada-lang.c:8622:                                   valaddr +
46a49
> gdb/buildsym.c:1146: code: OP eol: Do not use &&, or || at the end of a
line
gdb/buildsym.c:1146:          linetablesize = sizeof (struct linetable) +
68a72,75
> gdb/coff-pe-read.c:410: code: OP eol: Do not use &&, or || at the end of a
line
gdb/coff-pe-read.c:410:  secptr = (pe_header_offset + 4 + 20 +
> gdb/coff-pe-read.c:554: code: OP eol: Do not use &&, or || at the end of a
line
gdb/coff-pe-read.c:554:      unsigned long func_rva = pe_as32 (erva +
exp_funcbase +
> gdb/coff-pe-read.c:672: code: OP eol: Do not use &&, or || at the end of a
line
gdb/coff-pe-read.c:672:  secptr = (pe_header_offset + 4 + 20 +
> gdb/coffread.c:534: code: OP eol: Do not use &&, or || at the end of a
line
gdb/coffread.c:534:  stringtab_offset = symtab_offset +
160a168,169
> gdb/cp-support.c:1180: code: OP eol: Do not use &&, or || at the end of a
line
gdb/cp-support.c:1180:  sym_return_val = xmalloc ((sym_return_val_size + 1)
*
> gdb/cp-valprint.c:384: code: OP eol: Do not use &&, or || at the end of a
line
gdb/cp-valprint.c:384:          obstack_next_free
(&dont_print_statmem_obstack) -
162a172
> gdb/dbxread.c:1246: code: OP eol: Do not use &&, or || at the end of a
line
gdb/dbxread.c:1246:  psymtab_include_list = (const char **) alloca
(includes_allocated *
168a179
> gdb/dcache.c:380: code: OP eol: Do not use &&, or || at the end of a line
gdb/dcache.c:380:       db = xmalloc (offsetof (struct dcache_block, data) +
199a211,214
> gdb/dwarf2read.c:4984: code: OP eol: Do not use &&, or || at the end of a
line
gdb/dwarf2read.c:4984:  pst->n_global_syms = objfile->global_psymbols.next -
> gdb/dwarf2read.c:4986: code: OP eol: Do not use &&, or || at the end of a
line
gdb/dwarf2read.c:4986:  pst->n_static_syms = objfile->static_psymbols.next -
> gdb/dwarf2read.c:5412: code: OP eol: Do not use &&, or || at the end of a
line
gdb/dwarf2read.c:5412:  pst->n_global_syms = objfile->global_psymbols.next -
> gdb/dwarf2read.c:5414: code: OP eol: Do not use &&, or || at the end of a
line
gdb/dwarf2read.c:5414:  pst->n_static_syms = objfile->static_psymbols.next -
278a294
> gdb/hppa-tdep.c:429: code: OP eol: Do not use &&, or || at the end of a
line
gdb/hppa-tdep.c:429:        = ui->table[index].region_start + 4 *
287a304,311
> gdb/i386-tdep.c:5564: code: OP eol: Do not use &&, or || at the end of a
line
gdb/i386-tdep.c:5564:
I387_ST0_REGNUM (tdep) +
> gdb/i386-tdep.c:5631: code: OP eol: Do not use &&, or || at the end of a
line
gdb/i386-tdep.c:5631:
I387_ST0_REGNUM (tdep) +
> gdb/i386-tdep.c:5638: code: OP eol: Do not use &&, or || at the end of a
line
gdb/i386-tdep.c:5638:
I387_ST0_REGNUM (tdep) +
> gdb/i386-tdep.c:5658: code: OP eol: Do not use &&, or || at the end of a
line
gdb/i386-tdep.c:5658:
I387_ST0_REGNUM (tdep) +
> gdb/i386-tdep.c:5665: code: OP eol: Do not use &&, or || at the end of a
line
gdb/i386-tdep.c:5665:
I387_ST0_REGNUM (tdep) +
> gdb/i386-tdep.c:5679: code: OP eol: Do not use &&, or || at the end of a
line
gdb/i386-tdep.c:5679:
I387_ST0_REGNUM (tdep) +
> gdb/i386-tdep.c:5686: code: OP eol: Do not use &&, or || at the end of a
line
gdb/i386-tdep.c:5686:
I387_ST0_REGNUM (tdep) +
> gdb/i386-tdep.c:5704: code: OP eol: Do not use &&, or || at the end of a
line
gdb/i386-tdep.c:5704:
I387_ST0_REGNUM (tdep) +
390a415,416
> gdb/m2-valprint.c:278: code: OP eol: Do not use &&, or || at the end of a
line
gdb/m2-valprint.c:278:      if (TYPE_LENGTH (type) == 1 &&
> gdb/m2-valprint.c:333: code: OP eol: Do not use &&, or || at the end of a
line
gdb/m2-valprint.c:333:    if (TYPE_LENGTH (elttype) == 1 &&
409a436,437
> gdb/mdebugread.c:2390: code: OP eol: Do not use &&, or || at the end of a
line
gdb/mdebugread.c:2390:  psymtab_include_list = (const char **) alloca
(includes_allocated *
> gdb/mdebugread.c:3094: code: OP eol: Do not use &&, or || at the end of a
line
gdb/mdebugread.c:3094:                      alloca ((includes_allocated *=
2) *
428a457
> gdb/mips-linux-tdep.c:1018: code: OP eol: Do not use &&, or || at the end
of a line
gdb/mips-linux-tdep.c:1018:                            ireg + regs->fp0 +
502a532
> gdb/nto-procfs.c:1102: code: OP eol: Do not use &&, or || at the end of a
line
gdb/nto-procfs.c:1102:  argv = xmalloc (((strlen (allargs) + 1) / (unsigned)
2 + 2) *
514a545
> gdb/objc-lang.c:1456: code: OP eol: Do not use &&, or || at the end of a
line
gdb/objc-lang.c:1456:     mlist = read_memory_unsigned_integer
(class_str.methods +
515a547,548
> gdb/opencl-lang.c:990: code: OP eol: Do not use &&, or || at the end of a
line
gdb/opencl-lang.c:990:        memcpy (value_contents_writeable (ret) +
> gdb/p-valprint.c:106: code: OP eol: Do not use &&, or || at the end of a
line
gdb/p-valprint.c:106:                  extract_unsigned_integer (valaddr +
embedded_offset +
522a556
> gdb/ppc-linux-nat.c:897: code: OP eol: Do not use &&, or || at the end of
a line
gdb/ppc-linux-nat.c:897:  regcache_raw_collect (regcache, regno, regs +
525a560,563
> gdb/ppc-sysv-tdep.c:1508: code: OP eol: Do not use &&, or || at the end of
a line
gdb/ppc-sysv-tdep.c:1508:
tdep->ppc_gp0_regnum +
> gdb/ppc-sysv-tdep.c:1549: code: OP eol: Do not use &&, or || at the end of
a line
gdb/ppc-sysv-tdep.c:1549:
tdep->ppc_gp0_regnum +
> gdb/ppc-sysv-tdep.c:1927: code: OP eol: Do not use &&, or || at the end of
a line
gdb/ppc-sysv-tdep.c:1927:                 convert_typed_floating ((const
bfd_byte *) writebuf +
> gdb/ppc-sysv-tdep.c:1940: code: OP eol: Do not use &&, or || at the end of
a line
gdb/ppc-sysv-tdep.c:1940:                                         (bfd_byte
*) readbuf +
629a668
> gdb/remote-sim.c:689: code: OP eol: Do not use &&, or || at the end of a
line
gdb/remote-sim.c:689:    + strlen (') + strlen (gdb_sysroot) +
678a718,736
> gdb/rs6000-tdep.c:2664: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2664:      status = regcache_raw_read (regcache,
tdep->ppc_fp0_regnum +
> gdb/rs6000-tdep.c:2667: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2667: status = regcache_raw_read (regcache,
tdep->ppc_fp0_regnum +
> gdb/rs6000-tdep.c:2686: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2686:      regcache_raw_write (regcache,
tdep->ppc_fp0_regnum +
> gdb/rs6000-tdep.c:2688: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2688:      regcache_raw_write (regcache,
tdep->ppc_fp0_regnum +
> gdb/rs6000-tdep.c:2693: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2693:      regcache_raw_write (regcache,
tdep->ppc_fp0_regnum +
> gdb/rs6000-tdep.c:2695: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2695:      regcache_raw_write (regcache,
tdep->ppc_fp0_regnum +
> gdb/rs6000-tdep.c:2711: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2711:    status = regcache_raw_read (regcache,
tdep->ppc_vr0_regnum +
> gdb/rs6000-tdep.c:2717: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2717: status = regcache_raw_read (regcache,
tdep->ppc_fp0_regnum +
> gdb/rs6000-tdep.c:2720: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2720:   status = regcache_raw_read (regcache,
tdep->ppc_vsr0_upper_regnum +
> gdb/rs6000-tdep.c:2725: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2725: status = regcache_raw_read (regcache,
tdep->ppc_fp0_regnum +
> gdb/rs6000-tdep.c:2728: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2728:   status = regcache_raw_read (regcache,
tdep->ppc_vsr0_upper_regnum +
> gdb/rs6000-tdep.c:2745: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2745:    regcache_raw_write (regcache,
tdep->ppc_vr0_regnum +
> gdb/rs6000-tdep.c:2751: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2751: regcache_raw_write (regcache, tdep->ppc_fp0_regnum +
> gdb/rs6000-tdep.c:2753: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2753: regcache_raw_write (regcache,
tdep->ppc_vsr0_upper_regnum +
> gdb/rs6000-tdep.c:2758: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2758: regcache_raw_write (regcache, tdep->ppc_fp0_regnum +
> gdb/rs6000-tdep.c:2760: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:2760: regcache_raw_write (regcache,
tdep->ppc_vsr0_upper_regnum +
> gdb/rs6000-tdep.c:3561: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:3561:  from_xcoff_exec = info.abfd && info.abfd->format ==
bfd_object &&
> gdb/rs6000-tdep.c:3564: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:3564:  from_elf_exec = info.abfd && info.abfd->format ==
bfd_object &&
> gdb/rs6000-tdep.c:3588: code: OP eol: Do not use &&, or || at the end of a
line
gdb/rs6000-tdep.c:3588: wordsize = info.bfd_arch_info->bits_per_word /
708a767
> gdb/solib-sunos.c:554: code: OP eol: Do not use &&, or || at the end of a
line
gdb/solib-sunos.c:554:  flag_addr = debug_addr + (CORE_ADDR) ((char *)
&debug_copy.ldd_in_debugger -
814a874,875
> gdb/tui/tui-regs.c:82: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-regs.c:82:      num_lines =
(TUI_DATA_WIN->detail.data_display_info.regs_content_count /
> gdb/tui/tui-regs.c:127: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-regs.c:127:
TUI_DATA_WIN->detail.data_display_info.regs_column_count) -
825a887,889
> gdb/tui/tui-stack.c:377: code: OP eol: Do not use &&, or || at the end of
a line
gdb/tui/tui-stack.c:377:              start_line = (item->locator.line_no -
> gdb/tui/tui-win.c:750: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-win.c:750:    else if ((first_win->generic.height +
> gdb/tui/tui-win.c:766: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-win.c:766:    else if ((first_win->generic.height +
827a892,899
> gdb/tui/tui-win.c:1462: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-win.c:1462:       ok = ((new_height +
> gdb/tui/tui-win.c:1492: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-win.c:1492:       ok = ((first_win->generic.height +
> gdb/tui/tui-win.c:1498: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-win.c:1498:           total_height = new_height +
> gdb/tui/tui-win.c:1499: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-win.c:1499:             (first_win->generic.height +
> gdb/tui/tui-win.c:1523: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-win.c:1523:             total_height = new_height +
> gdb/tui/tui-win.c:1524: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-win.c:1524:               second_win->generic.height +
> gdb/tui/tui-win.c:1527: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-win.c:1527:             total_height = new_height +
> gdb/tui/tui-win.c:1528: code: OP eol: Do not use &&, or || at the end of a
line
gdb/tui/tui-win.c:1528:               first_win->generic.height +
829a902
> gdb/tui/tui-winsource.c:118: code: OP eol: Do not use &&, or || at the end
of a line
gdb/tui/tui-winsource.c:118:      sal.line = line_or_addr.u.line_no +
860a934
> gdb/valops.c:3641: code: OP eol: Do not use &&, or || at the end of a line
gdb/valops.c:3641:  new_val = value_at_lazy (real_type, value_address (argp)
- top +
882a957
> gdb/windows-nat.c:1010: code: OP eol: Do not use &&, or || at the end of a
line
gdb/windows-nat.c:1010:      base = (info.HighWord.Bits.BaseHi << 24) +
889a965
> gdb/windows-nat.c:2726: code: OP eol: Do not use &&, or || at the end of a
line
gdb/windows-nat.c:2726:      char *oldini = (char *) alloca (strlen
(homedir) +
899a976,981
> gdb/xcoffread.c:345: code: OP eol: Do not use &&, or || at the end of a
line
gdb/xcoffread.c:345:    xmalloc (sizeof (struct pending_stabs) +
> gdb/xcoffread.c:354: code: OP eol: Do not use &&, or || at the end of a
line
gdb/xcoffread.c:354:    xrealloc ((char *) *stabvector, sizeof (struct
pending_stabs) +
> gdb/xcoffread.c:480: code: OP eol: Do not use &&, or || at the end of a
line
gdb/xcoffread.c:480:    (sizeof (struct linetable) +
> gdb/xcoffread.c:2219: code: OP eol: Do not use &&, or || at the end of a
line
gdb/xcoffread.c:2219:  psymtab_include_list = (const char **) alloca
(includes_allocated *
> gdb/xcoffread.c:2619: code: OP eol: Do not use &&, or || at the end of a
line
gdb/xcoffread.c:2619:             alloca ((includes_allocated *= 2) *
> gdb/xcoffread.c:2955: code: OP eol: Do not use &&, or || at the end of a
line
gdb/xcoffread.c:2955:  stringtab_offset = symtab_offset +

Re: [RFA] ARI: Extend binary operator at EOL checks (was: About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt)

[Joel Brobecker]

>   Here is a propsoal for this,
> it extends the tested binray operator list from
> &&, ||, != and ==
> to
> &&, ||, !=, ==,+, -, / and *.
[...]
> I did not (yet) change the document of the ARI
> because this generates a long list of false ARI changes,
> thus I plan to do it later so that the true new ARI
> warnings generated by this change are not shadowed by
> this.

Not sure if you were waiting for feedback from us or not, before
checking it in? Looks like a nice addition to the current list.


-- 
Joel

RE: [RFA] ARI: Extend binary operator at EOL checks (was: About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt)

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : mercredi 20 mars 2013 16:52
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] ARI: Extend binary operator at EOL checks (was: About
New
> ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt)
> 
> >   Here is a propsoal for this,
> > it extends the tested binray operator list from
> > &&, ||, != and ==
> > to
> > &&, ||, !=, ==,+, -, / and *.
> [...]
> > I did not (yet) change the document of the ARI
> > because this generates a long list of false ARI changes,
> > thus I plan to do it later so that the true new ARI
> > warnings generated by this change are not shadowed by
> > this.
> 
> Not sure if you were waiting for feedback from us or not, before
> checking it in? Looks like a nice addition to the current list.
  Yes indeed, I take this as an approval and just committed
the change.

  Tomorrow we will get a big list of new ARI warnings :)...

Pierre Muller
as ARI maintainer

RE: [RFA] ARI: Extend binary operator at EOL checks (was: About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt)

[Pierre Muller]

> > À : Pierre Muller
> > Cc : gdb-patches@sourceware.org
> > Objet : Re: [RFA] ARI: Extend binary operator at EOL checks (was: About
> New
> > ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt)
> >
> > >   Here is a propsoal for this,
> > > it extends the tested binray operator list from
> > > &&, ||, != and ==
> > > to
> > > &&, ||, !=, ==,+, -, / and *.
> > [...]
> > > I did not (yet) change the document of the ARI
> > > because this generates a long list of false ARI changes,
> > > thus I plan to do it later so that the true new ARI
> > > warnings generated by this change are not shadowed by
> > > this.
> >
> > Not sure if you were waiting for feedback from us or not, before
> > checking it in? Looks like a nice addition to the current list.
>   Yes indeed, I take this as an approval and just committed
> the change.
> 
>   Tomorrow we will get a big list of new ARI warnings :)...

  My prediction power was once again defeated :(

  The reason is the change of machine hosting sourceware.org server.
It seems that both snapshots and ARI nightly page generation didn't restart
yet,
latest are from Monday 2AM, so before the switch.

  Frank, is it normal that the gdbadmin cron jobs are still not working?
If yes, could you give us an estimation of when it will be restarted?

Thanks in advance,

Pierre Muller
as GDB ARI maintainer

GDB nightly build failure (was ARI: Extend binary operator at EOL checks )

[Pierre Muller]

  Sorry Frank,
the crontab are already working, but they fail
because bison and GNU flex packages are not installed on the new system.

Could you please take care of this?

Pierre Muller
as ARI maintainer

Extract of $HOMER/log/gdb.current
dated March 21. 01.49

checking whether the target supports __sync_*_compare_and_swap... yes
checking whether ADDR_NO_RANDOMIZE is declared... (cached) yes
configure: updating cache .././config.cache
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depdir commands
mkdir -p -- .deps
config.status: executing default commands
Making info in doc
Making info in po
Making info in .
Making info in po
WARNING: `bison' missing on your system.  You should only need it if
         you modified a `.y' file.  You may need the `Bison' package
         in order for those modifications to take effect.  You can get
         `Bison' from any GNU archive site.
WARNING: `bison' missing on your system.  You should only need it if
         you modified a `.y' file.  You may need the `Bison' package
         in order for those modifications to take effect.  You can get
         `Bison' from any GNU archive site.
ada-lex.c missing and flex not available.
make[3]: *** [ada-lex.c] Error 1
make[2]: *** [do-proto-toplev] Error 1
make[1]: *** [gdb-tar] Error 2
make: *** [gdb.tar] Error 2


> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pierre Muller
> Envoyé : jeudi 21 mars 2013 09:19
> À : 'Frank Ch. Eigler'; 'Joel Brobecker'
> Cc : gdb-patches@sourceware.org
> Objet : RE: [RFA] ARI: Extend binary operator at EOL checks (was: About
New
> ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt)
> 
> > > À : Pierre Muller
> > > Cc : gdb-patches@sourceware.org
> > > Objet : Re: [RFA] ARI: Extend binary operator at EOL checks (was:
About
> > New
> > > ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt)
> > >
> > > >   Here is a propsoal for this,
> > > > it extends the tested binray operator list from
> > > > &&, ||, != and ==
> > > > to
> > > > &&, ||, !=, ==,+, -, / and *.
> > > [...]
> > > > I did not (yet) change the document of the ARI
> > > > because this generates a long list of false ARI changes,
> > > > thus I plan to do it later so that the true new ARI
> > > > warnings generated by this change are not shadowed by
> > > > this.
> > >
> > > Not sure if you were waiting for feedback from us or not, before
> > > checking it in? Looks like a nice addition to the current list.
> >   Yes indeed, I take this as an approval and just committed
> > the change.
> >
> >   Tomorrow we will get a big list of new ARI warnings :)...
> 
>   My prediction power was once again defeated :(
> 
>   The reason is the change of machine hosting sourceware.org server.
> It seems that both snapshots and ARI nightly page generation didn't
restart
> yet,
> latest are from Monday 2AM, so before the switch.
> 
>   Frank, is it normal that the gdbadmin cron jobs are still not working?
> If yes, could you give us an estimation of when it will be restarted?
> 
> Thanks in advance,
> 
> Pierre Muller
> as GDB ARI maintainer

Re: GDB nightly build failure (was ARI: Extend binary operator at EOL checks )

[Frank Ch. Eigler]

Hi -

> the crontab are already working, but they fail
> because bison and GNU flex packages are not installed on the new system.
> Could you please take care of this?

Done.

- FChE

RE: GDB nightly build failure (was ARI: Extend binary operator at EOL checks )

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Frank Ch. Eigler
> Envoyé : jeudi 21 mars 2013 12:40
> À : Pierre Muller
> Cc : 'Joel Brobecker'; gdb-patches@sourceware.org
> Objet : Re: GDB nightly build failure (was ARI: Extend binary operator at
> EOL checks )
> 
> Hi -
> 
> > the crontab are already working, but they fail
> > because bison and GNU flex packages are not installed on the new system.
> > Could you please take care of this?
> 
> Done.


  Thank you Frank,

  I started a do-all-snapshots script on sourceware.org.

Pierre Muller
as ARI maintainer

RE: GDB nightly build failure (was ARI: Extend binary operator at EOL checks )

[Pierre Muller]

  After a second round about missing msgfmt binary,
we finally got the crontab scripts to work again.
  At least the snapshot is updated and new ARI webpages were created 
as can be seen by the New ARI warning emails that just 
arrived on gdbp-atches mailing list!

  Thank you again Frank,

Pierre Muller
as ARI maintainer

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pierre Muller
> Envoyé : jeudi 21 mars 2013 13:42
> À : 'Frank Ch. Eigler'
> Cc : 'Joel Brobecker'; gdb-patches@sourceware.org
> Objet : RE: GDB nightly build failure (was ARI: Extend binary operator at
> EOL checks )
> 
> > -----Message d'origine-----
> > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] De la part de Frank Ch. Eigler
> > Envoyé : jeudi 21 mars 2013 12:40
> > À : Pierre Muller
> > Cc : 'Joel Brobecker'; gdb-patches@sourceware.org
> > Objet : Re: GDB nightly build failure (was ARI: Extend binary operator
at
> > EOL checks )
> >
> > Hi -
> >
> > > the crontab are already working, but they fail
> > > because bison and GNU flex packages are not installed on the new
system.
> > > Could you please take care of this?
> >
> > Done.
> 
> 
>   Thank you Frank,
> 
>   I started a do-all-snapshots script on sourceware.org.
> 
> Pierre Muller
> as ARI maintainer

Re: [RFA] ARI: Extend binary operator at EOL checks (was: About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt)

[Joel Brobecker]

>   The reason is the change of machine hosting sourceware.org server.
>   It seems that both snapshots and ARI nightly page generation didn't
>   restart yet, latest are from Monday 2AM, so before the switch.

They started, but source packaging failed, due to bison being missing.
I haven't reported yet, because we haven't received confirmation that
the transition is over, so not sure if it was OK to report already.

>   Frank, is it normal that the gdbadmin cron jobs are still not
>   working?  If yes, could you give us an estimation of when it will be
>   restarted?

Perhaps we should change the scripts to send to gdb-patches, rather
than to me personally. That way, everyone would see failure
notifications...

-- 
Joel