From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14070 invoked by alias); 11 Mar 2013 12:04:05 -0000 Received: (qmail 14057 invoked by uid 22791); 11 Mar 2013 12:04:03 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Mar 2013 12:03:54 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UF1SL-0002r0-7R from Hafiz_Abid@mentor.com for gdb-patches@sourceware.org; Mon, 11 Mar 2013 05:03:53 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 11 Mar 2013 05:03:53 -0700 Received: from abidh-ubunto1104 (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.1.289.1; Mon, 11 Mar 2013 12:03:51 +0000 Date: Mon, 11 Mar 2013 12:04:00 -0000 From: "Abid, Hafiz" Subject: Re: New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt To: In-Reply-To: <20130310020607.GA11887@sourceware.org> (from gdbadmin@sourceware.org on Sun Mar 10 02:06:07 2013) Message-ID: <1363003431.5561.0@abidh-ubunto1104> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00447.txt.bz2 On 10/03/13 02:06:07, GDB Administrator wrote: > 623a624 > > gdb/remote.c:11047: code: OP eol: Do not use &&, or || at the end=20=20 > of a line > gdb/remote.c:11047: if=20=20 > (remote_protocol_packets[PACKET_QTBuffer_size].support !=3D >=20 Hi All, I noticed the above ARI warning. I will apply the following if there=20=20 are no objections. I think it is obvious. Regards, Abid gdb/ChangeLog: * remote.c (remote_set_trace_buffer_size): Move !=3D operator to the start of next line to fix an ARI warning. diff --git a/gdb/remote.c b/gdb/remote.c index 8fc6b85..c4824e9 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -11056,8 +11056,8 @@ remote_get_min_fast_tracepoint_insn_len (void) static void remote_set_trace_buffer_size (LONGEST val) { - if (remote_protocol_packets[PACKET_QTBuffer_size].support !=3D - PACKET_DISABLE) + if (remote_protocol_packets[PACKET_QTBuffer_size].support + !=3D PACKET_DISABLE) { struct remote_state *rs =3D get_remote_state (); char *buf =3D rs->buf;