From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20579 invoked by alias); 11 Mar 2013 14:38:19 -0000 Received: (qmail 20545 invoked by uid 22791); 11 Mar 2013 14:38:18 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.201.45) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Mar 2013 14:38:07 +0000 Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2BEbtim072759 ; Mon, 11 Mar 2013 15:37:56 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms16.u-strasbg.fr [130.79.204.116]) by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2BEbtm2002668 ; Mon, 11 Mar 2013 15:37:55 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2BEbsOq009902 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Mon, 11 Mar 2013 15:37:54 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Abid, Hafiz'" , References: <20130310020607.GA11887@sourceware.org> (from gdbadmin@sourceware.org on Sun Mar 10 02:06:07 2013) <1363003431.5561.0@abidh-ubunto1104> In-Reply-To: <1363003431.5561.0@abidh-ubunto1104> Subject: About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt Date: Mon, 11 Mar 2013 14:38:00 -0000 Message-ID: <007701ce1e66$0383f480$0a8bdd80$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00464.txt.bz2 Thanks for the fast fix of this new ARI regression. Reading the comment of the rule shows that it is misleading, because it says that we should not use && or ||, but inside the script, it also looks =3D=3D or !=3D operators. I looked at the GNU coding standards, and those in fact talk about any binary operator... http://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting Should I: 1) modify the comment to also list !=3D and =3D=3D 2) extend the rule to also check for other binary operators? Pierre Muller=20 as ARI maintainer.... > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Abid, Hafiz > Envoy=E9=A0: lundi 11 mars 2013 13:04 > =C0=A0: gdb-patches@sourceware.org > Objet=A0: Re: New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-= 10- > gmt >=20 > On 10/03/13 02:06:07, GDB Administrator wrote: > > 623a624 > > > gdb/remote.c:11047: code: OP eol: Do not use &&, or || at the end > > of a line > > gdb/remote.c:11047: if > > (remote_protocol_packets[PACKET_QTBuffer_size].support !=3D > > >=20 > Hi All, > I noticed the above ARI warning. I will apply the following if there > are no objections. I think it is obvious. >=20 > Regards, > Abid >=20 > gdb/ChangeLog: >=20 > * remote.c (remote_set_trace_buffer_size): Move !=3D operator > to the start of next line to fix an ARI warning. >=20 >=20 > diff --git a/gdb/remote.c b/gdb/remote.c > index 8fc6b85..c4824e9 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -11056,8 +11056,8 @@ remote_get_min_fast_tracepoint_insn_len (void) > static void > remote_set_trace_buffer_size (LONGEST val) > { > - if (remote_protocol_packets[PACKET_QTBuffer_size].support !=3D > - PACKET_DISABLE) > + if (remote_protocol_packets[PACKET_QTBuffer_size].support > + !=3D PACKET_DISABLE) > { > struct remote_state *rs =3D get_remote_state (); > char *buf =3D rs->buf;