Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Abid, Hafiz" <hafiz_abid@mentor.com>
To: <gdb-patches@sourceware.org>
Subject: Re: New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt
Date: Mon, 11 Mar 2013 12:04:00 -0000	[thread overview]
Message-ID: <1363003431.5561.0@abidh-ubunto1104> (raw)
In-Reply-To: <20130310020607.GA11887@sourceware.org> (from	gdbadmin@sourceware.org on Sun Mar 10 02:06:07 2013)

On 10/03/13 02:06:07, GDB Administrator wrote:
> 623a624
> > gdb/remote.c:11047: code: OP eol: Do not use &&, or || at the end  
> of a line
> gdb/remote.c:11047:  if  
> (remote_protocol_packets[PACKET_QTBuffer_size].support !=
> 

Hi All,
I noticed the above ARI warning. I will apply the following if there  
are no objections. I think it is obvious.

Regards,
Abid

gdb/ChangeLog:

	* remote.c (remote_set_trace_buffer_size): Move != operator
	to the start of next line to fix an ARI warning.


diff --git a/gdb/remote.c b/gdb/remote.c
index 8fc6b85..c4824e9 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -11056,8 +11056,8 @@ remote_get_min_fast_tracepoint_insn_len (void)
  static void
  remote_set_trace_buffer_size (LONGEST val)
  {
-  if (remote_protocol_packets[PACKET_QTBuffer_size].support !=
-      PACKET_DISABLE)
+  if (remote_protocol_packets[PACKET_QTBuffer_size].support
+      != PACKET_DISABLE)
      {
        struct remote_state *rs = get_remote_state ();
        char *buf = rs->buf;


  reply	other threads:[~2013-03-11 12:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10  2:06 GDB Administrator
2013-03-11 12:04 ` Abid, Hafiz [this message]
2013-03-11 12:09   ` Pedro Alves
2013-03-11 14:38   ` About " Pierre Muller
2013-03-11 17:58     ` Joel Brobecker
2013-03-13 14:41       ` [RFA] ARI: Extend binary operator at EOL checks (was: About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt) Pierre Muller
2013-03-20 15:52         ` Joel Brobecker
2013-03-20 16:42           ` Pierre Muller
2013-03-21  8:31             ` Pierre Muller
2013-03-21 12:01               ` GDB nightly build failure (was ARI: Extend binary operator at EOL checks ) Pierre Muller
2013-03-21 12:42                 ` Frank Ch. Eigler
2013-03-21 13:31                   ` Pierre Muller
2013-03-21 13:42                     ` Pierre Muller
2013-03-21 15:19               ` [RFA] ARI: Extend binary operator at EOL checks (was: About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt) Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363003431.5561.0@abidh-ubunto1104 \
    --to=hafiz_abid@mentor.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox