About New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt

Pierre Muller
2013-03-11T14:38:19Z

Thanks for the fast fix of this new ARI regression.

Reading the comment of the rule shows that it is misleading,
because it says that we should not use && or ||,
but inside the script, it also looks == or != operators.

I looked at the GNU coding standards,
and those in fact talk about any binary operator...
http://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting

Should I:
1) modify the comment to also list != and ==
2) extend the rule to also check for other binary operators?

Pierre Muller
as ARI maintainer....

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Abid, Hafiz
> Envoyé : lundi 11 mars 2013 13:04
> À : gdb-patches@sourceware.org
> Objet : Re: New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-
> gmt
>
> On 10/03/13 02:06:07, GDB Administrator wrote:
> > 623a624
> > > gdb/remote.c:11047: code: OP eol: Do not use &&, or || at the end
> > of a line
> > gdb/remote.c:11047: if
> > (remote_protocol_packets[PACKET_QTBuffer_size].support !=
> >
>
> Hi All,
> I noticed the above ARI warning. I will apply the following if there
> are no objections. I think it is obvious.
>
> Regards,
> Abid
>
> gdb/ChangeLog:
>
> * remote.c (remote_set_trace_buffer_size): Move != operator
> to the start of next line to fix an ARI warning.
>
>
> diff --git a/gdb/remote.c b/gdb/remote.c
> index 8fc6b85..c4824e9 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -11056,8 +11056,8 @@ remote_get_min_fast_tracepoint_insn_len (void)
> static void
> remote_set_trace_buffer_size (LONGEST val)
> {
> - if (remote_protocol_packets[PACKET_QTBuffer_size].support !=
> - PACKET_DISABLE)
> + if (remote_protocol_packets[PACKET_QTBuffer_size].support
> + != PACKET_DISABLE)
> {
> struct remote_state *rs = get_remote_state ();
> char *buf = rs->buf;