From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18237 invoked by alias); 11 Mar 2013 12:09:51 -0000 Received: (qmail 18192 invoked by uid 22791); 11 Mar 2013 12:09:50 -0000 X-SWARE-Spam-Status: No, hits=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Mar 2013 12:09:40 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2BC9c1U013028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Mar 2013 08:09:38 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2BC9bP6032486; Mon, 11 Mar 2013 08:09:37 -0400 Message-ID: <513DC980.5000906@redhat.com> Date: Mon, 11 Mar 2013 12:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: "Abid, Hafiz" CC: gdb-patches@sourceware.org Subject: Re: New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt References: <1363003431.5561.0@abidh-ubunto1104> In-Reply-To: <1363003431.5561.0@abidh-ubunto1104> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00448.txt.bz2 On 03/11/2013 12:03 PM, Abid, Hafiz wrote: > On 10/03/13 02:06:07, GDB Administrator wrote: >> 623a624 >> > gdb/remote.c:11047: code: OP eol: Do not use &&, or || at the end of a line >> gdb/remote.c:11047: if (remote_protocol_packets[PACKET_QTBuffer_size].support != >> > > Hi All, > I noticed the above ARI warning. I will apply the following if there are no objections. I think it is obvious. Yes, thanks. Please go ahead. > > Regards, > Abid > > gdb/ChangeLog: > > * remote.c (remote_set_trace_buffer_size): Move != operator > to the start of next line to fix an ARI warning. > > > diff --git a/gdb/remote.c b/gdb/remote.c > index 8fc6b85..c4824e9 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -11056,8 +11056,8 @@ remote_get_min_fast_tracepoint_insn_len (void) > static void > remote_set_trace_buffer_size (LONGEST val) > { > - if (remote_protocol_packets[PACKET_QTBuffer_size].support != > - PACKET_DISABLE) > + if (remote_protocol_packets[PACKET_QTBuffer_size].support > + != PACKET_DISABLE) > { > struct remote_state *rs = get_remote_state (); > char *buf = rs->buf; -- Pedro Alves