From: Keith Seitz <keiths@redhat.com>
To: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA 1/2] Linespec rewrite (update 2)
Date: Thu, 05 Apr 2012 19:01:00 -0000 [thread overview]
Message-ID: <4F7DEBDE.1020803@redhat.com> (raw)
In-Reply-To: <CADPb22SncZ87gY3t4hQx3xpCh2aYfS0oPJPJd_hF0hxCryJPOg@mail.gmail.com>
On 04/05/2012 08:54 AM, Doug Evans wrote:
> On Thu, Apr 5, 2012 at 8:21 AM, Tom Tromey<tromey@redhat.com> wrote:
>>>>>>> "Keith" == Keith Seitz<keiths@redhat.com> writes:
>>
>> Keith> Given Doug's comments earlier today, I'm reposting anything that
>> Keith> hasn't already been approved or which changed. The easiest way to see
>> Keith> what's happened is, of course, by inspecting the commit history of the
>> Keith> branch.
>>
>> Keith> I'll follow-up separately with the other patch that was updated.
>>
>> I have no further comments. I think it looks great.
>>
>> I think at this point you just need Doug's ok.
>
> All I had were nits, so 'tis ok with me.
And with that, I've committed the lot.
Thank you to everyone who reviewed and played with the patchset!
Keith
next prev parent reply other threads:[~2012-04-05 19:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 23:18 Keith Seitz
2012-03-27 1:45 ` asmwarrior
2012-03-28 18:55 ` Tom Tromey
2012-03-27 13:56 ` Joel Brobecker
2012-03-27 14:31 ` Keith Seitz
2012-03-27 14:54 ` Joel Brobecker
2012-03-27 15:05 ` Joel Brobecker
2012-03-27 18:08 ` Keith Seitz
2012-03-28 20:46 ` Tom Tromey
2012-03-29 19:18 ` Keith Seitz
2012-03-30 15:34 ` Tom Tromey
2012-03-30 15:59 ` Keith Seitz
2012-03-30 16:37 ` Tom Tromey
2012-03-30 17:09 ` Joel Brobecker
2012-03-30 17:56 ` Tom Tromey
2012-03-30 18:05 ` Keith Seitz
2012-04-03 23:22 ` Keith Seitz
2012-04-05 15:22 ` Tom Tromey
2012-04-05 15:55 ` Doug Evans
2012-04-05 19:01 ` Keith Seitz [this message]
2012-07-22 19:33 ` Andreas Schwab
2012-07-23 17:57 ` Keith Seitz
2012-07-23 18:55 ` Tom Tromey
2012-07-23 21:13 ` Keith Seitz
2012-04-03 21:19 ` Doug Evans
2012-04-03 23:14 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7DEBDE.1020803@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox