From: Keith Seitz <keiths@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA 1/2] Linespec rewrite (update 2)
Date: Tue, 27 Mar 2012 18:08:00 -0000 [thread overview]
Message-ID: <4F71F615.1010306@redhat.com> (raw)
In-Reply-To: <20120327150528.GE2701@adacore.com>
On 03/27/2012 08:05 AM, Joel Brobecker wrote:
>> I am almost done with the extension of operator_bp.exp; I'll send it
>> when I've removed all the typos and thinkos...
>
> Here it is... As expected, it fails on HEAD, so cannot commit just
> yet. But PASSes with your previous iteration of the patch series,
> and now fails...
If it is failing on the "unimplemented" message, we can certainly whack
that from the patch -- it doesn't affect test results at all. In fact,
I've pushed this. The decision to issue an unimplemented error should
really come from create_linespec_from_sals, since that is the function
that actually does the work, and if mi/13139 ever gets implemented, this
will affect that as well.
I am worried that it appears to give a false positive on your tests with
no indication that anything has gone awry. [I worry because I intended
to actually implement symbol-relative offsets sometime in the future.]
Keith
next prev parent reply other threads:[~2012-03-27 18:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 23:18 Keith Seitz
2012-03-27 1:45 ` asmwarrior
2012-03-28 18:55 ` Tom Tromey
2012-03-27 13:56 ` Joel Brobecker
2012-03-27 14:31 ` Keith Seitz
2012-03-27 14:54 ` Joel Brobecker
2012-03-27 15:05 ` Joel Brobecker
2012-03-27 18:08 ` Keith Seitz [this message]
2012-03-28 20:46 ` Tom Tromey
2012-03-29 19:18 ` Keith Seitz
2012-03-30 15:34 ` Tom Tromey
2012-03-30 15:59 ` Keith Seitz
2012-03-30 16:37 ` Tom Tromey
2012-03-30 17:09 ` Joel Brobecker
2012-03-30 17:56 ` Tom Tromey
2012-03-30 18:05 ` Keith Seitz
2012-04-03 23:22 ` Keith Seitz
2012-04-05 15:22 ` Tom Tromey
2012-04-05 15:55 ` Doug Evans
2012-04-05 19:01 ` Keith Seitz
2012-07-22 19:33 ` Andreas Schwab
2012-07-23 17:57 ` Keith Seitz
2012-07-23 18:55 ` Tom Tromey
2012-07-23 21:13 ` Keith Seitz
2012-04-03 21:19 ` Doug Evans
2012-04-03 23:14 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71F615.1010306@redhat.com \
--to=keiths@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox