Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Keith Seitz <keiths@redhat.com>,
	"gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA 1/2] Linespec rewrite (update 2)
Date: Fri, 30 Mar 2012 17:09:00 -0000	[thread overview]
Message-ID: <20120330170913.GT2701@adacore.com> (raw)
In-Reply-To: <87r4waqc38.fsf@fleche.redhat.com>

> I read the followup more as a request for the feature to be added:
> 
> http://sourceware.org/ml/gdb-patches/2012-03/msg00907.html
> 
> However, I think that it is better to have this patch be as
> behavior-unchanging as reasonably possible and leave feature additions
> for follow-up patches.

My take on this is that the linespec was accepted before, and now
it is going to generate an error. What Keith highlighted was the fact
that the line number portion is currently ignored, which is definitely
a bug. I don't mind if we preserve the bug of ignoring the line number,
but I am a little less comfortable with error-ing out.

I don't mind if we create a temporary regression in that linespec
if that makes things easier. But it would be nice to be able to
not let it linger too long. I am hoping to have some time to look
at this maybe mid-April.

-- 
Joel


  reply	other threads:[~2012-03-30 17:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26 23:18 Keith Seitz
2012-03-27  1:45 ` asmwarrior
2012-03-28 18:55   ` Tom Tromey
2012-03-27 13:56 ` Joel Brobecker
2012-03-27 14:31   ` Keith Seitz
2012-03-27 14:54     ` Joel Brobecker
2012-03-27 15:05       ` Joel Brobecker
2012-03-27 18:08         ` Keith Seitz
2012-03-28 20:46 ` Tom Tromey
2012-03-29 19:18   ` Keith Seitz
2012-03-30 15:34     ` Tom Tromey
2012-03-30 15:59       ` Keith Seitz
2012-03-30 16:37         ` Tom Tromey
2012-03-30 17:09           ` Joel Brobecker [this message]
2012-03-30 17:56             ` Tom Tromey
2012-03-30 18:05               ` Keith Seitz
2012-04-03 23:22                 ` Keith Seitz
2012-04-05 15:22                   ` Tom Tromey
2012-04-05 15:55                     ` Doug Evans
2012-04-05 19:01                       ` Keith Seitz
2012-07-22 19:33                   ` Andreas Schwab
2012-07-23 17:57                     ` Keith Seitz
2012-07-23 18:55                       ` Tom Tromey
2012-07-23 21:13                         ` Keith Seitz
2012-04-03 21:19 ` Doug Evans
2012-04-03 23:14   ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120330170913.GT2701@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox