Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA 1/2] Linespec rewrite (update 2)
Date: Tue, 27 Mar 2012 14:54:00 -0000	[thread overview]
Message-ID: <20120327145425.GD2701@adacore.com> (raw)
In-Reply-To: <4F71CEF5.8030805@redhat.com>

> As you can see, the ":10" and ":25" were simply ignored. I've
> stepped through the code, and decode_variable will see "\"+\":10\n",
> but ada_name_for_lookup will return "+". From there on out, the
> ":10" is lost.

Hah! I thought that the line numbers were because GDB tries to find
the first line that matches, starting from the given one...

> Unless I'm missing something, this appears to be another special
> case of maintaining bug-for-bug compatibility.

I think that the syntax itself should be accepted, and that it's not
a bug (operators are functions). But we probably do not want to
perpetuate the bug where the line number is ignored :-).

> How would you like me to fix this?

I was hoping that we'd be able to handle this in the parser?
I am not completely familiar with the new code yet, so it's just
a wild guess.

I am almost done with the extension of operator_bp.exp; I'll send it
when I've removed all the typos and thinkos...

Thanks!
-- 
Joel


  reply	other threads:[~2012-03-27 14:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26 23:18 Keith Seitz
2012-03-27  1:45 ` asmwarrior
2012-03-28 18:55   ` Tom Tromey
2012-03-27 13:56 ` Joel Brobecker
2012-03-27 14:31   ` Keith Seitz
2012-03-27 14:54     ` Joel Brobecker [this message]
2012-03-27 15:05       ` Joel Brobecker
2012-03-27 18:08         ` Keith Seitz
2012-03-28 20:46 ` Tom Tromey
2012-03-29 19:18   ` Keith Seitz
2012-03-30 15:34     ` Tom Tromey
2012-03-30 15:59       ` Keith Seitz
2012-03-30 16:37         ` Tom Tromey
2012-03-30 17:09           ` Joel Brobecker
2012-03-30 17:56             ` Tom Tromey
2012-03-30 18:05               ` Keith Seitz
2012-04-03 23:22                 ` Keith Seitz
2012-04-05 15:22                   ` Tom Tromey
2012-04-05 15:55                     ` Doug Evans
2012-04-05 19:01                       ` Keith Seitz
2012-07-22 19:33                   ` Andreas Schwab
2012-07-23 17:57                     ` Keith Seitz
2012-07-23 18:55                       ` Tom Tromey
2012-07-23 21:13                         ` Keith Seitz
2012-04-03 21:19 ` Doug Evans
2012-04-03 23:14   ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120327145425.GD2701@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox