From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4656 invoked by alias); 5 Apr 2012 19:01:22 -0000 Received: (qmail 4643 invoked by uid 22791); 5 Apr 2012 19:01:19 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Apr 2012 19:00:49 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q35J0ntj028052 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Apr 2012 15:00:49 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q35J0l3Y015924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 5 Apr 2012 15:00:48 -0400 Message-ID: <4F7DEBDE.1020803@redhat.com> Date: Thu, 05 Apr 2012 19:01:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" Subject: Re: [RFA 1/2] Linespec rewrite (update 2) References: <4F70F8F7.503@redhat.com> <87zkb0wj1x.fsf@fleche.redhat.com> <4F74B583.6090008@redhat.com> <87obrertls.fsf@fleche.redhat.com> <4F75D859.1010907@redhat.com> <87r4waqc38.fsf@fleche.redhat.com> <20120330170913.GT2701@adacore.com> <87fwcqq8gl.fsf@fleche.redhat.com> <4F75F5F5.8070105@redhat.com> <4F7B8610.9070302@redhat.com> <87hawygq65.fsf@fleche.redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00080.txt.bz2 On 04/05/2012 08:54 AM, Doug Evans wrote: > On Thu, Apr 5, 2012 at 8:21 AM, Tom Tromey wrote: >>>>>>> "Keith" == Keith Seitz writes: >> >> Keith> Given Doug's comments earlier today, I'm reposting anything that >> Keith> hasn't already been approved or which changed. The easiest way to see >> Keith> what's happened is, of course, by inspecting the commit history of the >> Keith> branch. >> >> Keith> I'll follow-up separately with the other patch that was updated. >> >> I have no further comments. I think it looks great. >> >> I think at this point you just need Doug's ok. > > All I had were nits, so 'tis ok with me. And with that, I've committed the lot. Thank you to everyone who reviewed and played with the patchset! Keith