* [rfc target-side break conditions ] Testcase
@ 2012-02-08 23:17 Luis Gustavo
2012-02-14 14:29 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Luis Gustavo @ 2012-02-08 23:17 UTC (permalink / raw)
To: gdb-patches, Stan Shebs
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
Hi,
This is a simple testcase to exercise all the possible options of the
"condition-evaluation" breakpoint parameter.
If we're running in native mode, we expect GDB to display a warning, and
we make that test unsupported.
Luis
[-- Attachment #2: 0005-condition_evaluation_test.diff --]
[-- Type: text/x-patch, Size: 1869 bytes --]
2012-02-08 Luis Machado <lgustavo@codesourcery.com>
* gdb.base/cond-eval-mode.exp: New file.
Index: gdb/gdb/testsuite/gdb.base/cond-eval-mode.exp
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ gdb/gdb/testsuite/gdb.base/cond-eval-mode.exp 2012-02-08 20:39:00.987075003 -0200
@@ -0,0 +1,44 @@
+# Copyright 2012 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Test 'set breakpoint condition-evaluation' settings
+
+if { [prepare_for_testing break.exp "break" {break.c break1.c}] } {
+ return -1
+}
+
+runto main
+
+set test_host "set breakpoint condition-evaluation host"
+set test_auto "set breakpoint condition-evaluation auto"
+set test_target "set breakpoint condition-evaluation target"
+
+gdb_test_no_output $test_host
+gdb_test_no_output $test_auto
+
+# If target-side condition evaluation is not supported, this warning will be
+# displayed.
+set warning "warning: Target does not support breakpoint condition evaluation.\r\nUsing GDB evaluation mode instead.\r\n"
+
+gdb_test_multiple $test_target $test_target {
+ -re $warning {
+ unsupported $test_target
+ return -1
+ }
+
+ -re "\r\n$gdb_prompt " {
+ pass $test_target
+ }
+}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [rfc target-side break conditions ] Testcase
2012-02-08 23:17 [rfc target-side break conditions ] Testcase Luis Gustavo
@ 2012-02-14 14:29 ` Pedro Alves
2012-02-14 14:31 ` Pedro Alves
2012-02-22 15:33 ` Luis Gustavo
0 siblings, 2 replies; 6+ messages in thread
From: Pedro Alves @ 2012-02-14 14:29 UTC (permalink / raw)
To: Gustavo, Luis; +Cc: gdb-patches, Stan Shebs
I'm not seeing how this test is intended to catch as is. Any other
GDB output will PASS as long as it ends in the prompt, which usually
does.
On 02/08/2012 11:16 PM, Luis Gustavo wrote:
> +# If target-side condition evaluation is not supported, this warning will be
> +# displayed.
> +set warning "warning: Target does not support breakpoint condition evaluation.\r\nUsing GDB evaluation mode instead.\r\n"
> +
> +gdb_test_multiple $test_target $test_target {
> + -re $warning {
This should match $gdb_prompt as well. Otherwise, you confuse the following tests.
> + unsupported $test_target
> + return -1
> + }
> +
> + -re "\r\n$gdb_prompt " {
Did you intend to make sure that _only_ the prompt was output, like
gdb_tests_no_output? If so, then you need to make that:
-re "^$test_target\r\n$gdb_prompt $" {
> + pass $test_target
> + }
> +}
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [rfc target-side break conditions ] Testcase
2012-02-14 14:29 ` Pedro Alves
@ 2012-02-14 14:31 ` Pedro Alves
2012-02-22 15:33 ` Luis Gustavo
1 sibling, 0 replies; 6+ messages in thread
From: Pedro Alves @ 2012-02-14 14:31 UTC (permalink / raw)
To: Gustavo, Luis; +Cc: gdb-patches, Stan Shebs
On 02/14/2012 02:29 PM, Pedro Alves wrote:
> I'm not seeing how this test is intended to catch as is. Any other
s/how/what/ ...
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [rfc target-side break conditions ] Testcase
2012-02-14 14:29 ` Pedro Alves
2012-02-14 14:31 ` Pedro Alves
@ 2012-02-22 15:33 ` Luis Gustavo
2012-02-23 17:51 ` Pedro Alves
1 sibling, 1 reply; 6+ messages in thread
From: Luis Gustavo @ 2012-02-22 15:33 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches, Stan Shebs
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
On 02/14/2012 12:29 PM, Pedro Alves wrote:
> I'm not seeing how this test is intended to catch as is. Any other
> GDB output will PASS as long as it ends in the prompt, which usually
> does.
>
> On 02/08/2012 11:16 PM, Luis Gustavo wrote:
>> +# If target-side condition evaluation is not supported, this warning will be
>> +# displayed.
>> +set warning "warning: Target does not support breakpoint condition evaluation.\r\nUsing GDB evaluation mode instead.\r\n"
>> +
>> +gdb_test_multiple $test_target $test_target {
>> + -re $warning {
>
> This should match $gdb_prompt as well. Otherwise, you confuse the following tests.
>
>> + unsupported $test_target
>> + return -1
>> + }
>> +
>> + -re "\r\n$gdb_prompt " {
>
> Did you intend to make sure that _only_ the prompt was output, like
> gdb_tests_no_output? If so, then you need to make that:
>
> -re "^$test_target\r\n$gdb_prompt $" {
>
>> + pass $test_target
>> + }
>> +}
>
Fixed. Thanks for the input.
I apologize for the poor expect hackery.
Luis
[-- Attachment #2: 0005-condition_evaluation_test.diff --]
[-- Type: text/x-patch, Size: 1894 bytes --]
2012-02-22 Luis Machado <lgustavo@codesourcery.com>
* gdb.base/cond-eval-mode.exp: New file.
Index: gdb/gdb/testsuite/gdb.base/cond-eval-mode.exp
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ gdb/gdb/testsuite/gdb.base/cond-eval-mode.exp 2012-02-22 11:25:05.722553985 -0200
@@ -0,0 +1,44 @@
+# Copyright 2012 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Test 'set breakpoint condition-evaluation' settings
+
+if { [prepare_for_testing break.exp "break" {break.c break1.c}] } {
+ return -1
+}
+
+runto main
+
+set test_host "set breakpoint condition-evaluation host"
+set test_auto "set breakpoint condition-evaluation auto"
+set test_target "set breakpoint condition-evaluation target"
+
+gdb_test_no_output $test_host
+gdb_test_no_output $test_auto
+
+# If target-side condition evaluation is not supported, this warning will be
+# displayed.
+set warning "warning: Target does not support breakpoint condition evaluation.\r\nUsing GDB evaluation mode instead.\r\n"
+
+gdb_test_multiple $test_target $test_target {
+ -re $warning$gdb_prompt {
+ unsupported $test_target
+ return -1
+ }
+
+ -re "^$test_target\r\n$gdb_prompt $" {
+ pass $test_target
+ }
+}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [rfc target-side break conditions ] Testcase
2012-02-22 15:33 ` Luis Gustavo
@ 2012-02-23 17:51 ` Pedro Alves
2012-02-24 12:21 ` Luis Gustavo
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2012-02-23 17:51 UTC (permalink / raw)
To: Gustavo, Luis; +Cc: gdb-patches, Stan Shebs
On 02/22/2012 03:29 PM, Luis Gustavo wrote:
> Fixed. Thanks for the input.
Welcome.
> I apologize for the poor expect hackery.
No need for that. We all learn this stuff as we go.
Okay, with ...
> +gdb_test_multiple $test_target $test_target {
> + -re $warning$gdb_prompt {
-re "$warning$gdb_prompt $" {
unless there's a special requirement to allow things after the prompt.
Thanks,
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [rfc target-side break conditions ] Testcase
2012-02-23 17:51 ` Pedro Alves
@ 2012-02-24 12:21 ` Luis Gustavo
0 siblings, 0 replies; 6+ messages in thread
From: Luis Gustavo @ 2012-02-24 12:21 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches, Stan Shebs
On 02/23/2012 03:46 PM, Pedro Alves wrote:
> On 02/22/2012 03:29 PM, Luis Gustavo wrote:
>
>> Fixed. Thanks for the input.
>
> Welcome.
>
>> I apologize for the poor expect hackery.
>
> No need for that. We all learn this stuff as we go.
>
> Okay, with ...
>
>> +gdb_test_multiple $test_target $test_target {
>> + -re $warning$gdb_prompt {
>
> -re "$warning$gdb_prompt $" {
>
> unless there's a special requirement to allow things after the prompt.
Not really. We just want to make sure target-side evaluation shows as
unsupported when doing native GDB debugging.
Thanks,
Luis
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-24 12:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-08 23:17 [rfc target-side break conditions ] Testcase Luis Gustavo
2012-02-14 14:29 ` Pedro Alves
2012-02-14 14:31 ` Pedro Alves
2012-02-22 15:33 ` Luis Gustavo
2012-02-23 17:51 ` Pedro Alves
2012-02-24 12:21 ` Luis Gustavo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox