From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87892-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27105 invoked by alias); 14 Feb 2012 14:29:57 -0000
Received: (qmail 27096 invoked by uid 22791); 14 Feb 2012 14:29:57 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Feb 2012 14:29:41 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1EETXk1010794	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 14 Feb 2012 09:29:33 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1EETWi4012447;	Tue, 14 Feb 2012 09:29:33 -0500
Message-ID: <4F3A6FCC.7050906@redhat.com>
Date: Tue, 14 Feb 2012 14:29:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0
MIME-Version: 1.0
To: "Gustavo, Luis" <luis_gustavo@mentor.com>
CC: gdb-patches@sourceware.org, Stan Shebs <stanshebs@earthlink.net>
Subject: Re: [rfc target-side break conditions ] Testcase
References: <4F33026A.4000307@mentor.com>
In-Reply-To: <4F33026A.4000307@mentor.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00264.txt.bz2

I'm not seeing how this test is intended to catch as is.  Any other
GDB output will PASS as long as it ends in the prompt, which usually
does.

On 02/08/2012 11:16 PM, Luis Gustavo wrote:
> +# If target-side condition evaluation is not supported, this warning will be
> +# displayed.
> +set warning "warning: Target does not support breakpoint condition evaluation.\r\nUsing GDB evaluation mode instead.\r\n"
> +
> +gdb_test_multiple $test_target $test_target {
> +    -re $warning {

This should match $gdb_prompt as well.  Otherwise, you confuse the following tests.

> +	unsupported $test_target
> +	return -1
> +    }
> +
> +    -re "\r\n$gdb_prompt " {

Did you intend to make sure that _only_ the prompt was output, like
gdb_tests_no_output?  If so, then you need to make that:

        -re "^$test_target\r\n$gdb_prompt $" {

> +	pass $test_target
> +    }
> +}

-- 
Pedro Alves