From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19652 invoked by alias); 22 Feb 2012 15:29:25 -0000 Received: (qmail 19644 invoked by uid 22791); 22 Feb 2012 15:29:24 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Feb 2012 15:28:53 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1S0E7g-0001Ec-BO from Luis_Gustavo@mentor.com ; Wed, 22 Feb 2012 07:28:52 -0800 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 22 Feb 2012 07:28:52 -0800 Received: from [0.0.0.0] ([172.16.63.104]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 22 Feb 2012 07:28:51 -0800 Message-ID: <4F4509C0.9010406@mentor.com> Date: Wed, 22 Feb 2012 15:33:00 -0000 From: Luis Gustavo Reply-To: "Gustavo, Luis" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org, Stan Shebs Subject: Re: [rfc target-side break conditions ] Testcase References: <4F33026A.4000307@mentor.com> <4F3A6FCC.7050906@redhat.com> In-Reply-To: <4F3A6FCC.7050906@redhat.com> Content-Type: multipart/mixed; boundary="------------090407000009030502080500" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00477.txt.bz2 This is a multi-part message in MIME format. --------------090407000009030502080500 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1029 On 02/14/2012 12:29 PM, Pedro Alves wrote: > I'm not seeing how this test is intended to catch as is. Any other > GDB output will PASS as long as it ends in the prompt, which usually > does. > > On 02/08/2012 11:16 PM, Luis Gustavo wrote: >> +# If target-side condition evaluation is not supported, this warning will be >> +# displayed. >> +set warning "warning: Target does not support breakpoint condition evaluation.\r\nUsing GDB evaluation mode instead.\r\n" >> + >> +gdb_test_multiple $test_target $test_target { >> + -re $warning { > > This should match $gdb_prompt as well. Otherwise, you confuse the following tests. > >> + unsupported $test_target >> + return -1 >> + } >> + >> + -re "\r\n$gdb_prompt " { > > Did you intend to make sure that _only_ the prompt was output, like > gdb_tests_no_output? If so, then you need to make that: > > -re "^$test_target\r\n$gdb_prompt $" { > >> + pass $test_target >> + } >> +} > Fixed. Thanks for the input. I apologize for the poor expect hackery. Luis --------------090407000009030502080500 Content-Type: text/x-patch; name="0005-condition_evaluation_test.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0005-condition_evaluation_test.diff" Content-length: 1894 2012-02-22 Luis Machado * gdb.base/cond-eval-mode.exp: New file. Index: gdb/gdb/testsuite/gdb.base/cond-eval-mode.exp =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ gdb/gdb/testsuite/gdb.base/cond-eval-mode.exp 2012-02-22 11:25:05.722553985 -0200 @@ -0,0 +1,44 @@ +# Copyright 2012 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test 'set breakpoint condition-evaluation' settings + +if { [prepare_for_testing break.exp "break" {break.c break1.c}] } { + return -1 +} + +runto main + +set test_host "set breakpoint condition-evaluation host" +set test_auto "set breakpoint condition-evaluation auto" +set test_target "set breakpoint condition-evaluation target" + +gdb_test_no_output $test_host +gdb_test_no_output $test_auto + +# If target-side condition evaluation is not supported, this warning will be +# displayed. +set warning "warning: Target does not support breakpoint condition evaluation.\r\nUsing GDB evaluation mode instead.\r\n" + +gdb_test_multiple $test_target $test_target { + -re $warning$gdb_prompt { + unsupported $test_target + return -1 + } + + -re "^$test_target\r\n$gdb_prompt $" { + pass $test_target + } +} --------------090407000009030502080500--