[rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.

[rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 71 bytes --]

If frame is null, we will have crashed already from dereferencing it.


[-- Attachment #2: reversenull3.txt --]
[-- Type: text/plain, Size: 865 bytes --]

2011-03-01  Michael Snyder  <msnyder@vmware.com>

	* std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null.

Index: std-regs.c
===================================================================
RCS file: /cvs/src/src/gdb/std-regs.c,v
retrieving revision 1.31
diff -u -p -u -p -r1.31 std-regs.c
--- std-regs.c	1 Jan 2011 15:33:16 -0000	1.31
+++ std-regs.c	1 Mar 2011 20:42:48 -0000
@@ -70,11 +70,8 @@ value_of_builtin_frame_pc_reg (struct fr
       struct value *val = allocate_value (func_ptr_type);
       gdb_byte *buf = value_contents_raw (val);
 
-      if (frame == NULL)
-	memset (buf, 0, TYPE_LENGTH (value_type (val)));
-      else
-	gdbarch_address_to_pointer (gdbarch, func_ptr_type,
-				    buf, get_frame_pc (frame));
+      gdbarch_address_to_pointer (gdbarch, func_ptr_type,
+				  buf, get_frame_pc (frame));
       return val;
     }
 }

Re: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.

[Pedro Alves]

On Tuesday 01 March 2011 20:47:00, Michael Snyder wrote:
> If frame is null, we will have crashed already from dereferencing it.

Yeah, looks like a left over from before the "there's always
a frame" changes years ago.

> reversenull3.txt
>   2011-03-01  Michael Snyder  <msnyder@vmware.com>
> 
>         * std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null.

Okay.

-- 
Pedro Alves

Re: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.

[Michael Snyder]

Pedro Alves wrote:
> On Tuesday 01 March 2011 20:47:00, Michael Snyder wrote:
>> If frame is null, we will have crashed already from dereferencing it.
> 
> Yeah, looks like a left over from before the "there's always
> a frame" changes years ago.
> 
>> reversenull3.txt
>>   2011-03-01  Michael Snyder  <msnyder@vmware.com>
>>
>>         * std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null.
> 
> Okay.
> 

Thanks, checked in.

Re: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.

[Pedro Alves]

On Tuesday 01 March 2011 21:39:59, Pedro Alves wrote:
> On Tuesday 01 March 2011 20:47:00, Michael Snyder wrote:
> > If frame is null, we will have crashed already from dereferencing it.
> 
> Yeah, looks like a left over from before the "there's always
> a frame" changes years ago.
> 
> > reversenull3.txt
> >   2011-03-01  Michael Snyder  <msnyder@vmware.com>
> > 
> >         * std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null.
> 
> Okay.

Similar dead code in value_of_builtin_frame_fp_reg btw.

-- 
Pedro Alves

Re: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.

[Michael Snyder]

Pedro Alves wrote:
> On Tuesday 01 March 2011 21:39:59, Pedro Alves wrote:
>> On Tuesday 01 March 2011 20:47:00, Michael Snyder wrote:
>>> If frame is null, we will have crashed already from dereferencing it.
>> Yeah, looks like a left over from before the "there's always
>> a frame" changes years ago.
>>
>>> reversenull3.txt
>>>   2011-03-01  Michael Snyder  <msnyder@vmware.com>
>>>
>>>         * std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null.
>> Okay.
> 
> Similar dead code in value_of_builtin_frame_fp_reg btw.
> 

Got it.  Checked in.