From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12541 invoked by alias); 1 Mar 2011 20:47:08 -0000 Received: (qmail 12529 invoked by uid 22791); 1 Mar 2011 20:47:07 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 20:47:01 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 9A4D11F004 for ; Tue, 1 Mar 2011 12:47:00 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id 969258EEA4 for ; Tue, 1 Mar 2011 12:47:00 -0800 (PST) Message-ID: <4D6D5B44.9020500@vmware.com> Date: Tue, 01 Mar 2011 20:47:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame. Content-Type: multipart/mixed; boundary="------------000102000806040802020709" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00043.txt.bz2 This is a multi-part message in MIME format. --------------000102000806040802020709 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 71 If frame is null, we will have crashed already from dereferencing it. --------------000102000806040802020709 Content-Type: text/plain; name="reversenull3.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="reversenull3.txt" Content-length: 865 2011-03-01 Michael Snyder * std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null. Index: std-regs.c =================================================================== RCS file: /cvs/src/src/gdb/std-regs.c,v retrieving revision 1.31 diff -u -p -u -p -r1.31 std-regs.c --- std-regs.c 1 Jan 2011 15:33:16 -0000 1.31 +++ std-regs.c 1 Mar 2011 20:42:48 -0000 @@ -70,11 +70,8 @@ value_of_builtin_frame_pc_reg (struct fr struct value *val = allocate_value (func_ptr_type); gdb_byte *buf = value_contents_raw (val); - if (frame == NULL) - memset (buf, 0, TYPE_LENGTH (value_type (val))); - else - gdbarch_address_to_pointer (gdbarch, func_ptr_type, - buf, get_frame_pc (frame)); + gdbarch_address_to_pointer (gdbarch, func_ptr_type, + buf, get_frame_pc (frame)); return val; } } --------------000102000806040802020709--